Uh oh!
There was an error while loading. Please reload this page.
Fix a few syntax issues in shell scripts - #62102
Conversation
ghost
commented
Nov 27, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
9520955 to
ab8553cCompare```sh # git remote add dotnet https://github.com/dotnet/runtime && git pull --rebase dotnet main if uname 2>/devnull | grep -q Darwin; then space=" " fi git show --name-only --pretty="" HEAD...dotnet/main |\ xargs -I{} sh -c "test -f {} && sed -i$space'' 's/[[:space:]]*$//' {}" ```
ab8553c to
17c6508CompareUh oh!
There was an error while loading. Please reload this page.
ghost
commented
Nov 29, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThis delta updates shell scripts for consistency. In particular, avoid mixing Bash and Unix shell syntax by replacing:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Nov 30, 2021
safern
commented
Nov 30, 2021
@radical could you please look at the staging failure? |
antonfirsov
commented
Jul 27, 2022
This change broke the (non-mandatory) SslStress pipeline. When touching |
This delta updates shell scripts for consistency. In particular, avoid mixing Bash and Unix shell syntax by replacing:
[ $x == $y ]and[[ $x = $y ]]with[[ $x == $y ]][[ $x ]] && [[ $y ]]and[ $x ] && [ $y ]with[[ $x && $y ]][ ! -z $x ]and[ $x != "" ]with[ -n $x ][ ! -n $x ]and[ $x == "" ]with[ -z $x ]! $x == $ywith$x != $y#!/bin/bashwith#!/usr/bin/env bash[[with[in files with/bin/shshebang