Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Allow runtimeconfig StartupHooks and Environment StartupHooks to both be present - #62124
Merged
Merged
Conversation
… to both be present
…_HOOKS" to both be present
ghost
commented
Nov 29, 2021
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #61461 to release/6.0 Customer ImpactTestingRisk
|
vitek-karas
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #61461 to release/6.0
/cc @agocke@tomdegoede
Customer Impact
Customer testing revealed that specifying StartupHooks by both environment and runtimeconfig setting results in an error, instead of the expected result, which is combining the two sets.
Testing
Unit tests added, manual testing.
Risk
Low risk -- small, focused change only in startup hooks.