Skip to content

Improve SuperPMI temp filename creation - #62169

Merged
BruceForstall merged 2 commits into
dotnet:mainfrom
BruceForstall:FixSpmiNameMunging
Dec 1, 2021
Merged

Improve SuperPMI temp filename creation#62169
BruceForstall merged 2 commits into
dotnet:mainfrom
BruceForstall:FixSpmiNameMunging

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Nov 30, 2021

Copy link
Copy Markdown
Contributor
  1. Disallow all non-ASCII characters from the MC filename.
  2. Disallow ( and ) in filenames.
  3. To improve uniqueness, always append an 8-character random number
    to the filename.

@BruceForstall
Improve SuperPMI temp filename creation
668f57c
1. Disallow all non-ASCII characters from the MC filename.
2. Disallow `(` and `)` in filenames.
3. To improve uniqueness, always append an 8-character random number
to the filename.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 30, 2021
@ghost

ghost commented Nov 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Disallow all non-ASCII characters from the MC filename.
  2. Disallow ( and ) in filenames.
  3. To improve uniqueness, always append an 8-character random number
    to the filename.
Author:BruceForstall
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall

BruceForstall commented Nov 30, 2021

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak @dotnet/jit-contrib PTAL

kunalspathak
kunalspathak approved these changes Dec 1, 2021
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall
BruceForstall merged commit 4cf4661 into dotnet:mainDec 1, 2021
@BruceForstall
BruceForstall deleted the FixSpmiNameMunging branch December 1, 2021 00:18
@joshpetersonjoshpeterson mentioned this pull request Dec 1, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceForstall@kunalspathak