Skip to content

Fix mono debugger thread block when wait for attach - #62175

Merged
lambdageek merged 8 commits into
dotnet:mainfrom
srxqds:fix-mono-gc-thread
Dec 2, 2021
Merged

Fix mono debugger thread block when wait for attach#62175
lambdageek merged 8 commits into
dotnet:mainfrom
srxqds:fix-mono-gc-thread

Conversation

@srxqds

Copy link
Copy Markdown
Contributor

fix: #62128

@ghostghost added area-Debugger-mono community-contribution Indicates that the PR has been added by a community member labels Nov 30, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

fix: #62128

Author:srxqds
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@srxqdssrxqds changed the title Fix mono gc threadFix mono debugger thread not set flagsNov 30, 2021
@srxqdssrxqds changed the title Fix mono debugger thread not set flagsFix mono debugger thread block when wait for attachNov 30, 2021

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srxqds Could you also change MONO_REQ_GC_SAFE_MODE to MONO_REQ_GC_UNSAFE_MODE at the beginning of wait_for_attach.

@srxqds

Copy link
Copy Markdown
ContributorAuthor

@srxqds Could you also change MONO_REQ_GC_SAFE_MODE to MONO_REQ_GC_UNSAFE_MODE at the beginning of wait_for_attach.

done

@lambdageek
lambdageek merged commit 7b0a6b5 into dotnet:mainDec 2, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mono] call GC.Collect(); block the main thread won't resume

2 participants

@srxqds@lambdageek