Uh oh!
There was an error while loading. Please reload this page.
[mono] Fix warnings with recent clang/gcc - #62244
Merged
Merged
Conversation
akoeplinger
commented
Dec 1, 2021
Member
- Unused/unset variables in hot_reload.c
- Misleading indentation in aot-compiler.c
- Cast to smaller integer type in method-to-ir.c
akoeplinger
requested review from
SamMonoRT, imhameed, marek-safar and vargaz
as code ownersDecember 1, 2021 17:52
lambdageek
approved these changes
Dec 1, 2021
lambdageek
left a comment
Member
There was a problem hiding this comment.
C usually uses #if 0 not FALSE
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com>
akoeplinger
commented
Dec 2, 2021
MemberAuthor
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.