Skip to content

Move FabricBot rules to Config-As-Code - #62297

Merged
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:fabricbot-configuration-as-code
Dec 6, 2021
Merged

Move FabricBot rules to Config-As-Code#62297
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:fabricbot-configuration-as-code

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Dec 2, 2021

Copy link
Copy Markdown
Member

Following #7442 this PR transfers our FabricBot automation rules to Config-as-Code. Also adds a bit of documentation pointing to the new rule editing workflow.

@eiriktsarpaliseiriktsarpalis self-assigned this Dec 2, 2021
@ghost

ghost commented Dec 2, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Following #7442 this PR transfers our FabricBot automation rules to Config-as-Code. Also adds a bit of documentation pointing to the new rule editing workflow.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-Meta

Milestone:-

danmoseley
danmoseley approved these changes Dec 2, 2021
View reviewed changes
Comment threaddocs/infra/automation.md Outdated
@eiriktsarpalisDan Moseley
Update docs/infra/automation.md
5499d28
Co-authored-by: Dan Moseley <danmose@microsoft.com>
marek-safar
marek-safar reviewed Dec 3, 2021
View reviewed changes
Comment thread.github/fabricbot.json
@eiriktsarpalis

eiriktsarpalis commented Dec 3, 2021

Copy link
Copy Markdown
MemberAuthor

Since it's a Friday, I'll hold off from merging this until next week. I'll also need to update the FB configuration dump to the most recent state if needed.

karelz
karelz reviewed Dec 3, 2021
View reviewed changes
Comment thread.github/fabricbot.json
@lewing

lewing commented Dec 3, 2021•
edited
Loading

Copy link
Copy Markdown
Member

who has permission to edit the fabricbot config?

@eiriktsarpalis

eiriktsarpalis commented Dec 6, 2021

Copy link
Copy Markdown
MemberAuthor

who has permission to edit the fabricbot config?

Currently a handful of team members have permissions in the FabricBot portal, but after this is merged anybody should be able to submit a PR.

@eiriktsarpalis
eiriktsarpalis merged commit f8871cb into dotnet:mainDec 6, 2021
@eiriktsarpalis
eiriktsarpalis deleted the fabricbot-configuration-as-code branch December 6, 2021 12:24
@eiriktsarpaliseiriktsarpalis mentioned this pull request Dec 7, 2021
Closed
18 tasks
@ghostghost locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@karelzkarelzkarelz approved these changes
@agockeagockeAwaiting requested review from agocke
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@terrajobstterrajobstAwaiting requested review from terrajobst
@jkotasjkotasAwaiting requested review from jkotas
@eerhardteerhardtAwaiting requested review from eerhardt
@ericstjericstjAwaiting requested review from ericstj
@jeffschwMSFTjeffschwMSFTAwaiting requested review from jeffschwMSFT
@davidwrightondavidwrightonAwaiting requested review from davidwrighton
@joperezrjoperezrAwaiting requested review from joperezr
@trylektrylekAwaiting requested review from trylek
@safernsafernAwaiting requested review from safern
@rokonecrokonecAwaiting requested review from rokonec
@tkapintkapinAwaiting requested review from tkapin
@mangod9mangod9Awaiting requested review from mangod9
@JulieLeeMSFTJulieLeeMSFTAwaiting requested review from JulieLeeMSFT
@GrabYourPitchforksGrabYourPitchforksAwaiting requested review from GrabYourPitchforks
+1 more reviewer
@danmoseleydanmoseleydanmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-Meta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eiriktsarpalis@lewing@marek-safar@karelz@danmoseley