Uh oh!
There was an error while loading. Please reload this page.
Use Spans on Go() methods for Code Gen engines - #62324
Conversation
ghost
commented
Dec 3, 2021
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsContributes to #59629 Finishing the work to use Spans over the Emitter and Compiler now that @stephentoub work has been merged.
|
joperezr
commented
Dec 3, 2021
After this changes are in, for all 3 engines (interpreted, compiler, and emitter) we should only be using
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
left a comment
There was a problem hiding this comment.
Looks good. There's going to be some conflicts with #62318, but whoever merges second can resolve those easily (mostly this is changing code that gets deleted there).
joperezr
commented
Dec 3, 2021
I'm fine being the one that resolves the conflicts so feel free to go ahead and merge, and I'll react to the changes. |
stephentoub
commented
Dec 3, 2021
@joperezr, why don't you go ahead and get yours merged. Mine's blocked on a potential mono interpreter issue. |
5e00ef1 to
92f761cCompare
Contributes to #59629
Finishing the work to use Spans over the Emitter and Compiler now that @stephentoub work has been merged.