Skip to content

Fix superpmi.py collect script - #62347

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:FixSpmiScript
Dec 3, 2021
Merged

Fix superpmi.py collect script#62347
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:FixSpmiScript

Conversation

@BruceForstall

Copy link
Copy Markdown
Contributor

Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: 'CoreclrArguments' object has no attribute 'compile'

Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: `'CoreclrArguments' object has no attribute 'compile'`
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost

ghost commented Dec 3, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Collect also does a replay, so needs all the replay arguments set to something.
Fixes this error: 'CoreclrArguments' object has no attribute 'compile'

Author:BruceForstall
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall

Copy link
Copy Markdown
ContributorAuthor

fyi @SeanWoo -- regression from #62217. There's an unfortunately subtle issue with argument processing for superpmi.py collect.

@BruceForstall

Copy link
Copy Markdown
ContributorAuthor

@kunalspathak @dotnet/jit-contrib PTAL

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall
BruceForstall merged commit 62b2333 into dotnet:mainDec 3, 2021
@BruceForstall
BruceForstall deleted the FixSpmiScript branch December 3, 2021 22:45
@ghostghost locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceForstall@kunalspathak