Uh oh!
There was an error while loading. Please reload this page.
Fixes an issue with FeatureSIMD=0 and ArmBase.Yield - #62351
Merged
Conversation
…t/hwintrinsiclistarm64.h
…nsic and simplify the remaining logic in src/coreclr/jit/hwintrinsicarm64.cpp
ghost
commented
Dec 3, 2021
Tagging subscribers to this area: @JulieLeeMSFT |
echesakov
commented
Dec 3, 2021
ContributorAuthor
@dotnet/jit-contrib @tannergooding PTAL |
BruceForstall
approved these changes
Dec 3, 2021
echesakov
commented
Dec 3, 2021
ContributorAuthor
/azp run runtime-coreclr jitstress-isas-arm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
tannergooding
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that
ArmBase.Yieldis not expanding as intrinsic whenFeatureSIMD=0.This shouldn't be a case.
In addition, this marks the intrinsic with
HW_Flag_NoFloatingPointUsed.Fixes#62117