Skip to content

[wasm] Re-enable windows wasm AOT tests - #62352

Merged
radical merged 6 commits into
dotnet:mainfrom
radical:enable-windows-aot
Dec 5, 2021
Merged

[wasm] Re-enable windows wasm AOT tests#62352
radical merged 6 commits into
dotnet:mainfrom
radical:enable-windows-aot

Conversation

@radical

@radicalradical commented Dec 3, 2021

Copy link
Copy Markdown
Member

They had been disabled earlier because of #61721

@radical
[wasm] Re-enable windows wasm AOT tests
098fc9e
They had been disabled earlier because of dotnet#61721
@radicalradical added arch-wasm WebAssembly architecture area-Codegen-AOT-mono labels Dec 3, 2021
@ghost

ghost commented Dec 3, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

They had been disabled earlier because of #61721

Author:radical
Assignees:-
Labels:

arch-wasm, area-Codegen-AOT-mono

Milestone:-

@radical

radical commented Dec 3, 2021

Copy link
Copy Markdown
MemberAuthor

cc @radekdoulik@vargaz

@radical

radical commented Dec 3, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 3, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Dec 3, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 3, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 3, 2021
lewing
lewing approved these changes Dec 3, 2021
View reviewed changes

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when green

This was referenced Dec 3, 2021
Closed
Closed
@radical

radical commented Dec 4, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 4, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 4, 2021
Merged
Closed
@radical

radical commented Dec 4, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 4, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radicalradical removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 4, 2021
@radical

radical commented Dec 4, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 4, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical
radical merged commit fedf64f into dotnet:mainDec 5, 2021
@radical
radical deleted the enable-windows-aot branch December 5, 2021 01:15
@runfoapprunfoappBot mentioned this pull request Dec 6, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@vargazvargazAwaiting requested review from vargaz
@radekdoulikradekdoulikAwaiting requested review from radekdoulik

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Codegen-AOT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@lewing