Skip to content

JIT: three fixes for OSR - #62367

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:OSROnByDefaultPrep
Dec 4, 2021
Merged

JIT: three fixes for OSR#62367
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:OSROnByDefaultPrep

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Found when trying to enable OSR by default and prospecting for arm64 support.

  • Explicitly initalize the OSR step variable.
  • Prevent fgOptimizeUncondBranchToSimpleCond from changing the scratch entry
    BB to have conditional flow.
  • Retain runtime supplied patchpoint info when cleaning up after an altjit failure.

Found when trying to enable OSR by default and prospecting for arm64 support.
* Explicitly initalize the OSR step variable.
* Prevent `fgOptimizeUncondBranchToSimpleCond` from changing the scratch entry
BB to have conditional flow.
* Retain runtime supplied patchpoint info when cleaning up after an altjit failure.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost

ghost commented Dec 3, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Found when trying to enable OSR by default and prospecting for arm64 support.

  • Explicitly initalize the OSR step variable.
  • Prevent fgOptimizeUncondBranchToSimpleCond from changing the scratch entry
    BB to have conditional flow.
  • Retain runtime supplied patchpoint info when cleaning up after an altjit failure.
Author:AndyAyersMS
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib

Pulls in the two fixes from #61934 and one from a local fork where I'm working on arm64 support.

@AndyAyersMS
AndyAyersMS merged commit 43b58c2 into dotnet:mainDec 4, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyAyersMS@BruceForstall