Uh oh!
There was an error while loading. Please reload this page.
Change assert in NewPutArg(), so it is consistent with transformation done by fgMorphArgs() - #62379
Merged
Merged
Conversation
…returns false. Change the assert, so it checks that the argument type is TYP_DOUBLE in Lowering::NewPutArg() in src/coreclr/jit/lower.cpp
ghost
commented
Dec 4, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsOn Arm32 lower asserts in As far as I can tell, the transformation is legal, but the way lower validates the type and size of an argument is incorrect - it calls The change makes the assert look similar to the one in morph https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/morph.cpp#L3676 Fixes #62249 @dotnet/jit-contrib
|
EgorBo
approved these changes
Dec 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Arm32 lower asserts in
NewPutArg()after morph does transformation fromOBJ(struct<CanBeReinterpretedAsDouble, 8>, byRef)toIND(double, byRef)for stack arguments passed by value.As far as I can tell, the transformation is legal, but the way lower validates the type and size of an argument is incorrect - it calls
varTypeIsSIMD()which always returnsfalseon Arm32.The change makes the assert look similar to the one in morph https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/morph.cpp#L3676
Fixes#62249
@dotnet/jit-contrib