Skip to content

JIT: handle more cases for MOD/DIV -> UMOD/UDIV transformation - #62394

Merged
EgorBo merged 8 commits into
dotnet:mainfrom
EgorBo:jit-recognize-umod
Dec 17, 2021
Merged

JIT: handle more cases for MOD/DIV -> UMOD/UDIV transformation#62394
EgorBo merged 8 commits into
dotnet:mainfrom
EgorBo:jit-recognize-umod

Conversation

@EgorBo

@EgorBoEgorBo commented Dec 4, 2021

Copy link
Copy Markdown
Member

Closes#62326

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 4, 2021
@ghost

ghost commented Dec 4, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #62326

Author:EgorBo
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

SingleAccretion
SingleAccretion reviewed Dec 4, 2021
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
SingleAccretion
SingleAccretion reviewed Dec 5, 2021
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment threadsrc/coreclr/jit/gentree.cpp
Comment threadsrc/coreclr/jit/morph.cpp Outdated
Comment threadsrc/coreclr/jit/morph.cpp Outdated
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
EgorBoand others added 2 commits December 6, 2021 12:57
@EgorBo@SingleAccretion
Apply suggestions from code review
44f1499
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@EgorBo
Address feedback
6f277ea
@runfoapprunfoappBot mentioned this pull request Dec 6, 2021
Closed
@EgorBo

EgorBo commented Dec 17, 2021

Copy link
Copy Markdown
MemberAuthor

@dotnet/jit-contrib PTAL, I need IsNeverNegative() this PR introduces in my other PR 🙂

@EgorBo
EgorBo merged commit a6de632 into dotnet:mainDec 17, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+1 more reviewer
@SingleAccretionSingleAccretionSingleAccretion left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JIT does not recognize Vector<T>.Count and Vector{128|256}.Count is unsigned in div / mod

3 participants

@EgorBo@jakobbotsch@SingleAccretion