[wasm] Emscripten 2.0.34 bump by radekdoulik · Pull Request #62499 · dotnet/runtime

radekdoulik · 2021-12-07T20:48:28Z

Performance wise it looks similar to 2.0.23. Didn't notice any regression here. The managed startup is slightly slower, in second run I measured 223ms, so it is probably just measurement error.

measurement	2.0.23 time	2.0.34
AppStart, Page show	63.0000ms	63.4458ms
AppStart, Reach managed	222.5600ms	226.1304ms
Exceptions, NoExceptionHandling	0.0921us	0.0843us
Exceptions, TryCatch	0.0955us	0.0885us
Exceptions, TryCatchThrow	0.0026ms	0.0026ms
Exceptions, TryCatchFilter	0.1018us	0.0929us
Exceptions, TryCatchFilterInline	0.0869us	0.0800us
Exceptions, TryCatchFilterThrow	0.0033ms	0.0034ms
Exceptions, TryCatchFilterThrowApplies	0.0025ms	0.0025ms
Json, non-ASCII text serialize	9.0376ms	7.9638ms
Json, non-ASCII text deserialize	14.0856ms	11.7460ms
Json, small serialize	0.2351ms	0.2203ms
Json, small deserialize	0.3556ms	0.3359ms
Json, large serialize	69.6667ms	63.6420ms
Json, large deserialize	99.6792ms	92.1754ms
WebSocket, PartialSend 1B	0.0017ms	0.0017ms
WebSocket, PartialSend 64KB	0.0653ms	0.0658ms
WebSocket, PartialSend 1MB	0.9636ms	0.9364ms
WebSocket, PartialReceive 1B	0.0026ms	0.0025ms
WebSocket, PartialReceive 10KB	0.0060ms	0.0040ms
WebSocket, PartialReceive 100KB	0.0000us	0.0000us

vargaz · 2021-12-08T17:30:08Z

Might need this as well:

 <_EmccCommonFlags Include="-s ENVIRONMENT=&quot;web,webview,worker,node,shell&quot;" />

Newer versions of emscripten no longer build with 'shell' support by default, i.e. running under v8.

vargaz · 2021-12-09T03:03:08Z

Fix for the build failure:
https://gist.github.com/vargaz/4bfce768ed19d283ddc31be124cc82a9

Co-authored-by: Zoltan Varga <vargaz@gmail.com>

src/mono/mono/mini/mini-runtime.c:3407:25: error: ‘invoke’ undeclared (first use in this function); did you mean ‘revoke’? 3407 | invoke = mono_marshal_get_runtime_invoke_dynamic ();

Environment setting https://github.com/emscripten-core/emscripten/blob/2.0.34/src/settings.js#L616-L641 From emscripten 2.0.25 release notes - Support for the 'shell' environment is now disabled by default. Running under `d8`, `js`, or `jsc` is not something that most emscripten users ever want to do, so including the support code is, more often than not, unnecessary. Users who want shell support can enable it by including 'shell' in `-s ENVIRONMENT` (dotnet#14535). Example of the the size increase for bench sample: -a--- 12/10/2021 3:35 PM 382113 dotnet.js -a--- 12/13/2021 10:37 AM 383589 dotnet.js

radekdoulik · 2021-12-13T10:09:04Z

Related: #62708

…-34-bump

https://github.com/emscripten-core/emscripten/blob/2fda25eea756c78c8cb024aa5b6c2b188bf7990f/src/settings.js#L1173-L1176 -s EXPORT_ES6 is link option

…-34-bump

lewing · 2022-01-31T19:48:00Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-31T19:48:23Z

Azure Pipelines successfully started running 1 pipeline(s).

lewing · 2022-02-01T02:48:44Z

looks like we need to bump Emscripten in icu dotnet/icu#177

…-34-bump

lewing · 2022-02-01T15:47:27Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-01T15:47:48Z

Azure Pipelines successfully started running 1 pipeline(s).

radekdoulik · 2022-02-02T15:26:50Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-02T15:27:17Z

Azure Pipelines successfully started running 1 pipeline(s).

To avoid these errors: WasmApp.Native.targets(342,5): error : Failed to compile .../Microsoft.CodeAnalysis.CSharp.dll.bc -> /datadisks/disk1/work/B9F209B7/w/B1710A2F/e/wasm_build/obj/wasm/for-build/Microsoft.CodeAnalysis.CSharp.dll.o WasmApp.Native.targets(342,5): error : emcc: warning: linker setting ignored during compilation: 'TOTAL_MEMORY' [-Wunused-command-line-argument] WasmApp.Native.targets(342,5): error : emcc: warning: linker setting ignored during compilation: 'ERROR_ON_UNDEFINED_SYMBOLS' [-Wunused-command-line-argument]

radekdoulik · 2022-02-02T16:09:24Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-02T16:09:44Z

Azure Pipelines successfully started running 1 pipeline(s).

…-34-bump

radekdoulik · 2022-02-02T17:48:01Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-02T17:48:26Z

Azure Pipelines successfully started running 1 pipeline(s).

radekdoulik · 2022-02-02T21:38:36Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-02T21:38:57Z

Azure Pipelines successfully started running 1 pipeline(s).

When running with nodejs, the managed app would exit with code 42, but node would exit with 1. Use `process.exit` for node, instead of `mono_wasm_exit`.

radical · 2022-02-03T00:39:23Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-03T00:39:44Z

Azure Pipelines successfully started running 1 pipeline(s).

radical · 2022-02-03T04:01:40Z

Failures:

Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests - timing out, likely OOM
[wasm][aot][windows] Crash in Microsoft.Extensions.HostFactoryResolver.Tests with emsdk 2.0.34 #64724
[wasm][aot][windows] Crash in Microsoft.Extensions.Logging.Tests #64725
[wasm] NodeJS samples failing at exit with emsdk 2.0.34 #64727

These will be investigated after this PR is merged.

sbomer · 2022-02-03T19:09:29Z

Why was this merged with known runtime-extra-platforms failures? I ask because we are trying to keep get runtime and runtime-extra-platforms to green to make it easier to detect new failures. Would it be reasonable to disable the failing tests before merging in the future? Just curious what we can do to meet our build health goals without unnecessarily slowing down development.

radical · 2022-02-03T19:19:10Z

Why was this merged with known runtime-extra-platforms failures?

This was part of a bigger mess, which started with an update dependencies PR from emsdk getting merged, which bumped the emscripten version being used, which broken Wasm.Build.Tests (on main, and PRs), which got mixed with many helix queues getting removed, and all that combining to cause a badly red main, and lots of PRs being blocked. Merging this unblocked them, and made main much less red. And I opened a PR to disable those tests today (#64759).

I ask because we are trying to keep get runtime and runtime-extra-platforms to green to make it easier to detect new failures. Would it be reasonable to disable the failing tests before merging in the future? Just curious what we can do to meet our build health goals without unnecessarily slowing down development.

I completely agree with that, and avoid merging with any failures caused by the PR. But this was an unusual case.

sbomer · 2022-02-03T19:21:15Z

Thanks @radical, I appreciate the explanation

This reverts commit 724c4e1.

Initial changes for emscripten 2.0.34
0a6c904

radekdoulik added the area-Build-mono label Dec 7, 2021

radekdoulik added 2 commits December 8, 2021 13:34

Use emcc-link.rsp in build targets
1c2f989

Use updated docker images
f74d8b9

vargaz approved these changes Dec 9, 2021
View reviewed changes

Radek Doulikand others added 4 commits December 9, 2021 17:02

Fix compiler warnings
20f59e5
Co-authored-by: Zoltan Varga <vargaz@gmail.com>

Put --profiling-funcs to _EmccLinkFlags
31197d9

Fix build
2063241
src/mono/mono/mini/mini-runtime.c:3407:25: error: ‘invoke’ undeclared (first use in this function); did you mean ‘revoke’? 3407 | invoke = mono_marshal_get_runtime_invoke_dynamic ();

radekdoulik added 3 commits December 21, 2021 08:29

Merge remote-tracking branch 'origin/main' into pr-emscripten-34-bump
1f0048f

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…
17c0117
…-34-bump

Add emcc-link.rsp to PlatformManifestFileEntry
11e2ce5

runfoappBot mentioned this pull request Jan 4, 2022
RegexKnownPatternTests.TerminationInNonBacktrackingVsBackTracking Failures on Linux ARM32 #62873
Closed

pavelsavara reviewed Jan 7, 2022
View reviewed changes

Comment threadsrc/mono/wasm/wasm.proj Outdated

radekdoulik added 4 commits January 7, 2022 21:09

Feedback
3eb44cf
https://github.com/emscripten-core/emscripten/blob/2fda25eea756c78c8cb024aa5b6c2b188bf7990f/src/settings.js#L1173-L1176 -s EXPORT_ES6 is link option

Use new Emscripten workload
e189182

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…
2f3227a
…-34-bump

Remove unused variable
4ffd9a0

Add the emcc-link.rsp
38a7107

radekdoulik added 2 commits February 1, 2022 14:49

Bump dotnet icu
afabf1c

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…
5318de4
…-34-bump

lewing marked this pull request as ready for review February 1, 2022 15:48

runfoappBot mentioned this pull request Feb 2, 2022
system.diagnostics.tests.providermetadatatests.getprovidernames_assertproperties #64153
Open

Do not add linker flags to compilation
814279b

radekdoulik added 2 commits February 2, 2022 18:43

Merge remote-tracking branch 'remotes/origin/main' into pr-emscripten…
4fb4543
…-34-bump

Bump emscripten workload
56460a5

Update windows helix queues
1c2f7a5

lewingand others added 2 commits February 2, 2022 17:31

Merge branch 'main' into pr-emscripten-34-bump
6ab30fc

[wasm] Fix WBT running with nodejs
e411b47
When running with nodejs, the managed app would exit with code 42, but node would exit with 1. Use `process.exit` for node, instead of `mono_wasm_exit`.

lewing approved these changes Feb 3, 2022
View reviewed changes

This was referenced Feb 3, 2022
[wasm][aot][windows] Crash in Microsoft.Extensions.HostFactoryResolver.Tests with emsdk 2.0.34#64724
Closed
[wasm][aot][windows] Crash in Microsoft.Extensions.Logging.Tests#64725
Closed
[wasm] NodeJS samples failing at exit with emsdk 2.0.34#64727
Closed

radical merged commit 724c4e1 into dotnet:mainFeb 3, 2022

runfoappBot mentioned this pull request Feb 3, 2022
normal-system.text.json.sourcegeneration.roslyn3.11.unit.tests work item #64762
Closed

radekdoulik added a commit to radekdoulik/runtime that referenced this pull request Feb 17, 2022
Revert "[wasm] Emscripten 2.0.34 bump (dotnet#62499)"
5a35c90
This reverts commit 724c4e1.

ghost locked as resolved and limited conversation to collaborators Mar 6, 2022

Uh oh!

Conversation

radekdoulik commented Dec 7, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vargaz commented Dec 8, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vargaz commented Dec 9, 2021

Uh oh!

radekdoulik commented Dec 13, 2021

Uh oh!

Uh oh!

lewing commented Jan 31, 2022

Uh oh!

azure-pipelinesBot commented Jan 31, 2022

Uh oh!

lewing commented Feb 1, 2022

Uh oh!

lewing commented Feb 1, 2022

Uh oh!

azure-pipelinesBot commented Feb 1, 2022

Uh oh!

radekdoulik commented Feb 2, 2022

Uh oh!

azure-pipelinesBot commented Feb 2, 2022

Uh oh!

radekdoulik commented Feb 2, 2022

Uh oh!

azure-pipelinesBot commented Feb 2, 2022

Uh oh!

radekdoulik commented Feb 2, 2022

Uh oh!

azure-pipelinesBot commented Feb 2, 2022

Uh oh!

radekdoulik commented Feb 2, 2022

Uh oh!

azure-pipelinesBot commented Feb 2, 2022

Uh oh!

radical commented Feb 3, 2022

Uh oh!

azure-pipelinesBot commented Feb 3, 2022

Uh oh!

radical commented Feb 3, 2022

Uh oh!

sbomer commented Feb 3, 2022

Uh oh!

radical commented Feb 3, 2022

Uh oh!

sbomer commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

radekdoulik commented Dec 7, 2021•
edited
Loading

vargaz commented Dec 8, 2021•
edited
Loading