Uh oh!
There was an error while loading. Please reload this page.
Improve ARM64 JIT disassembly - #62557
Merged
Merged
Conversation
ghost
commented
Dec 9, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsCurrently work-in-progress as it currently regresses a few 'add' and 'sub' instructions. Various JIT disassembly fixes for ARM64.
|
TIHan
commented
Dec 9, 2021
Uh oh!
There was an error while loading. Please reload this page.
TIHan
commented
Dec 9, 2021
Uh oh!
There was an error while loading. Please reload this page.
TIHanforce-pushed
the
arm64-jit-disassem-fixes1
branch
from
December 9, 2021 18:18
33b29aa to
eafa3b4CompareTIHanforce-pushed
the
arm64-jit-disassem-fixes1
branch
from
December 9, 2021 18:58
eafa3b4 to
813a10fCompareTIHan
commented
Dec 13, 2021
ContributorAuthor
This is ready. |
AndyAyersMS
commented
Dec 14, 2021
Member
@BruceForstall PTAL
Are you planning on handling more of these cases in subsequent changes, or are we done? |
TIHan
commented
Dec 14, 2021
ContributorAuthor
I'm planning on making more PRs in the future to fix more cases. |
BruceForstall
self-requested a review
December 15, 2021 00:16
BruceForstall
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the ARM64 JIT disassembly by displaying the ext register by its correct size in 'cmp', 'add', and 'sub'.
This should handle more cases from: #36846
Left is without the change. Right is with the change.
These are the only diffs.
@dotnet/jit-contrib