Skip to content

Add NativeAOT to build - #62569

Merged
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:build
Dec 14, 2021
Merged

Add NativeAOT to build#62569
MichalStrehovsky merged 1 commit into
dotnet:mainfrom
MichalStrehovsky:build

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Dec 9, 2021•
edited
Loading

Copy link
Copy Markdown
Member

NativeAOT becomes part of the clr subset.

The NativeAOT runtime and libraries are a clr.nativeaotlibs subset.
The NativeAOT object writer (not built by default) is clr.objwriter subset.
The AOT compiler is part of the existing clr.tools subset.

@ghost

ghost commented Dec 9, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichalStrehovskyMichalStrehovsky added the area-Infrastructure-coreclr Only use for closed issues label Dec 9, 2021
@ghost

ghost commented Dec 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

NativeAOT becomes part of the clr subset.

The NativeAOT runtime and libraries are a clr.nativeaotlibs subset.
The NativeAOT object writer (not built by default) is clr.objwriter subset.
The AOT compiler is part of the existing clr.tools subset.

Author:MichalStrehovsky
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@MichalStrehovsky
MichalStrehovskyforce-pushed the build branch 15 times, most recently from 960b904 to f1b7ff6CompareDecember 10, 2021 08:32
marek-safar
marek-safar reviewed Dec 10, 2021
View reviewed changes
Comment threadeng/Subsets.props Outdated

@marek-safarmarek-safarDec 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are non-coreclr pieces located under coreclr (same applies to tools) ?

@MichalStrehovskyMichalStrehovskyDec 10, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NativeAOT is a flavor of CoreCLR

@marek-safarmarek-safarDec 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is no runtime agnostic tool or assembly in NativeAOT right now?

@MichalStrehovskyMichalStrehovskyDec 10, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be moving files out as we unify the runtimes. E.g. a lot of src\coreclr\nativeaot\System.Private.Reflection.Core\src is basically src\libraries\System.Reflection.MetadataLoadContext\src but they need to be unified as we figure out the right shape of a common reflection stack (also shared with Mono). There's also bits and pieces in NativeAOT's corelib that we would like to share. Now that we have the things here, it's easier to do such refactorings.

@MichalStrehovsky

MichalStrehovsky commented Dec 10, 2021

Copy link
Copy Markdown
MemberAuthor

Cc @safern@jkoritzinsky for general build-infra. This is enabling NativeAOT bits in the CoreCLR build.

kant2002
kant2002 reviewed Dec 11, 2021
View reviewed changes
Comment threadsrc/coreclr/nativeaot/Runtime/CommonMacros.h Outdated
kant2002
kant2002 reviewed Dec 11, 2021
View reviewed changes
Comment threadeng/native/functions.cmake Outdated
@MichalStrehovsky

MichalStrehovsky commented Dec 14, 2021

Copy link
Copy Markdown
MemberAuthor

@dotnet/runtime-infrastructure this is adding NativeAOT to the CLR build.

build.cmd clr -rc Debug -lc Release gets about 15% slower. It's 15% because we are building the NativeAOT bits 3 times on Windows because we need a flavor of the runtime with/without the Server GC, and one more flavor with Server GC and Control Flow Guard enabled. This is to accommodate user-facing configurability options. The overhead is smaller outside Windows because there's no CFG flavor.

@MichalStrehovsky
MichalStrehovsky merged commit 5f9a532 into dotnet:mainDec 14, 2021
@MichalStrehovsky
MichalStrehovsky deleted the build branch December 14, 2021 05:23
safern
safern reviewed Dec 14, 2021
View reviewed changes
Comment threadeng/Subsets.props
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+clr.nativeaotlibs+')) and '$(NativeAotSupported)' == 'true'">
<ProjectToBuild Include="$(CoreClrProjectRoot)nativeaot\System.Private.CoreLib\src\System.Private.CoreLib.csproj" Category="clr" />

@safernsafernDec 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not include these as a wildcard?

@MichalStrehovskyMichalStrehovskyDec 14, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! #62820

safern
safern reviewed Dec 14, 2021
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a question, LGTM

@ghostghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@safernsafernsafern left review comments
@jkotasjkotasjkotas approved these changes
+1 more reviewer
@kant2002kant2002kant2002 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MichalStrehovsky@marek-safar@kant2002@jkotas@safern