Skip to content

[wasm] Allow the main.js file to keep it's name - #62576

Merged
pavelsavara merged 5 commits into
dotnet:mainfrom
pavelsavara:wasm_main_js_name
Dec 10, 2021
Merged

[wasm] Allow the main.js file to keep it's name#62576
pavelsavara merged 5 commits into
dotnet:mainfrom
pavelsavara:wasm_main_js_name

Conversation

@pavelsavara

Copy link
Copy Markdown
Member

This will be useful to be able to have .mjs and .cjs main files, so that NodeJs could load it properly.

@pavelsavarapavelsavara added the arch-wasm WebAssembly architecture label Dec 9, 2021
@pavelsavarapavelsavara added this to the 7.0.0 milestone Dec 9, 2021
@ghost

ghost commented Dec 9, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This will be useful to be able to have .mjs and .cjs main files, so that NodeJs could load it properly.

Author:pavelsavara
Assignees:-
Labels:

arch-wasm

Milestone:7.0.0

@pavelsavara
pavelsavara marked this pull request as ready for review December 9, 2021 17:11
Comment threadsrc/mono/wasm/build/WasmApp.targets Outdated
@radical

Copy link
Copy Markdown
Member

/azp run runtime-manual

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

Copy link
Copy Markdown
Member

cc @thaystg to confirm that this doesn't break debugger tests

pavelsavaraand others added 3 commits December 10, 2021 10:47
Co-authored-by: Ankit Jain <radical@gmail.com>
@pavelsavara

Copy link
Copy Markdown
MemberAuthor

I tested debugger locally.

@pavelsavara
pavelsavara merged commit 7f09104 into dotnet:mainDec 10, 2021
@pavelsavara
pavelsavara deleted the wasm_main_js_name branch January 4, 2022 13:06
@ghostghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara@radical