Skip to content

[wasm] Decrease the startup ceremony - #62587

Merged
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_run_api
Dec 10, 2021
Merged

[wasm] Decrease the startup ceremony#62587
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_run_api

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Dec 9, 2021

Copy link
Copy Markdown
Member

Decrease the startup ceremony

  • default config when empty DotnetModuleConfig
  • default onAbort, including error propagation to ready promise
  • new API MONO.mono_run_main_and_exit and MONO.mono_run_main
  • console-v8-cjs sample

@ghost

ghost commented Dec 9, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

maraf
maraf approved these changes Dec 10, 2021
View reviewed changes

@marafmaraf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara
pavelsavara merged commit 25c2073 into dotnet:mainDec 10, 2021
@pavelsavarapavelsavara mentioned this pull request Dec 10, 2021
Merged
@pavelsavara
pavelsavara deleted the wasm_run_api branch January 4, 2022 13:06
@ghostghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marafmarafmaraf approved these changes
@kgkgAwaiting requested review from kg
@radekdoulikradekdoulikAwaiting requested review from radekdoulik
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara@maraf