Skip to content

HTTP/2: Improve incoming header performance - #62614

Merged
JamesNK merged 1 commit into
mainfrom
github-action/sync-aspnetcore-1639095896
Dec 11, 2021
Merged

HTTP/2: Improve incoming header performance#62614
JamesNK merged 1 commit into
mainfrom
github-action/sync-aspnetcore-1639095896

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR was automatically generated to sync shared code changes from aspnetcore. Fixesdotnet/aspnetcore#18943

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR was automatically generated to sync shared code changes from aspnetcore. Fixes dotnet/aspnetcore#18943

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@JamesNKJamesNK changed the title Sync shared code from aspnetcoreHTTP/2: Improve incoming header performanceDec 10, 2021
@JamesNK

Copy link
Copy Markdown
Member

Sync changes from dotnet/aspnetcore#38834

@JamesNK

Copy link
Copy Markdown
Member

Changes:

  1. Add StaticTableIndex to field entries. Used by Kestrel to set header values faster.
  2. HPackDecoder uses the new OnDynamicIndexedHeader method to set a header using an entry from the dynamic table. If we know the header is set from the dynamic table then the name and value must previously have been validated. Because Kestrel uses that interface publically a DIM was added to keep it a non-breaking change.

Taking advantage of both of these changes are is opt-in. SocketsHttpHandler won't use it unless you choose to.

@JamesNK

Copy link
Copy Markdown
Member

This PR has test failures from System.Net.Http.Functional.Tests, System.Net.Quic.Functional.Tests and System.Net.Sockets.Tests.

Is that because of changes here, or are they pre-existing known test failures?

@JamesNK
JamesNKforce-pushed the github-action/sync-aspnetcore-1639095896 branch from db36cd7 to e732692CompareDecember 11, 2021 02:33
@JamesNK

Copy link
Copy Markdown
Member

Rebase fixed build.

@JamesNK
JamesNK merged commit 57a740c into mainDec 11, 2021
@JamesNK
JamesNK deleted the github-action/sync-aspnetcore-1639095896 branch December 11, 2021 05:27
@JamesNKJamesNK added this to the 7.0.0 milestone Dec 11, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

2 participants

@JamesNK@ManickaP