Uh oh!
There was an error while loading. Please reload this page.
Update spmi asp.net script to collect some osr method contexts - #62635
Merged
AndyAyersMS merged 1 commit intoDec 11, 2021
Merged
Conversation
Collect both non-pgo and pgo cases. For non-pgo, set OSR to trigger immediately when any patchpoint is hit to maximize number of cases collected. For PGO, set OSR to trigger once we've got a bit of profile data gathered by the Tier0 method.
ghost
commented
Dec 10, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsCollect both non-pgo and pgo cases. For non-pgo, set OSR to trigger immediately
|
AndyAyersMS
commented
Dec 10, 2021
MemberAuthor
cc @dotnet/jit-contrib Recent collection stats: |
EgorBo
reviewed
Dec 10, 2021
| # note tricks to get one element tuples | ||
| runtime_options_list = [("Dummy=0",), ("TieredCompilation=0", ), ("TieredPGO=1", "TC_QuickJitForLoops=1"), ("TieredPGO=1", "TC_QuickJitForLoops=1", "ReadyToRun=0")] | ||
| runtime_options_list = [("Dummy=0",), ("TieredCompilation=0", ), ("TieredPGO=1", "TC_QuickJitForLoops=1"), ("TieredPGO=1", "TC_QuickJitForLoops=1", "ReadyToRun=0"), |
Member
There was a problem hiding this comment.
should first items have TC_OnStackReplacement=0 as you're planning to enable it by default?
MemberAuthor
There was a problem hiding this comment.
I suppose so, though with the current defaults (~50,000 hits to patchpoints before a transition) very few methods will end up with OSR. In practice it won't make much difference.
The bigger impact will be from changing the default for QJFL.
EgorBo
approved these changes
Dec 10, 2021
BruceForstall
approved these changes
Dec 10, 2021
AndyAyersMS
commented
Dec 10, 2021
MemberAuthor
Note this means that if we alter the format of Or at least, trigger a new collection. I don't expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect both non-pgo and pgo cases. For non-pgo, set OSR to trigger immediately
when any patchpoint is hit to maximize number of cases collected. For PGO, set
OSR to trigger once we've got a bit of profile data gathered by the Tier0 method.