Skip to content

Make mono runtime tests stop using patching in CI; remove dependency on coreclr - #62652

Merged
safern merged 1 commit into
dotnet:mainfrom
naricc:naricc/remove-patching
Dec 14, 2021
Merged

Make mono runtime tests stop using patching in CI; remove dependency on coreclr#62652
safern merged 1 commit into
dotnet:mainfrom
naricc:naricc/remove-patching

Conversation

@naricc

@nariccnaricc commented Dec 10, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR removes the patching step for mono in CI, and removes the dependency on coreclr, for desktop configurations.

Contributes to #58266
Fixes#43952

@ghost

ghost commented Dec 10, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@naricc

naricc commented Dec 10, 2021

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-manual

@azure-pipelines

azure-pipelinesBot commented Dec 10, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

lambdageek
lambdageek reviewed Dec 10, 2021
View reviewed changes
Comment threadeng/pipelines/mono/templates/build-job.yml
@lambdageek

lambdageek commented Dec 11, 2021•
edited
Loading

Copy link
Copy Markdown
Member

✅ runtime (Mono minijit Pri0 Runtime Tests Run OSX x64 release) Successful in 53m
✅ runtime (Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release) Successful in 54m

@naricc seems like it's working! 🎉

@nariccnaricc changed the title [Draft] Make mono runtime tests stop using patching in CI; remove dependency on coreclrMake mono runtime tests stop using patching in CI; remove dependency on coreclrDec 13, 2021
@naricc
naricc marked this pull request as ready for review December 13, 2021 16:58
safern
safern approved these changes Dec 13, 2021
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider collapsing the Mono Desktop jobs to use the global-build template as the mono build is fast.

@safern

safern commented Dec 14, 2021

Copy link
Copy Markdown
Member

Failures in runtime-manual are unrelated.

@safern
safern merged commit 09100bd into dotnet:mainDec 14, 2021
@naricc

naricc commented Dec 14, 2021

Copy link
Copy Markdown
ContributorAuthor

@safern Do we already have a seperate issue for that (collapsing to global-build template)? If not I will create one.

This was referenced Dec 14, 2021
Open
Open
lambdageek added a commit to lambdageek/runtime that referenced this pull request Dec 14, 2021
@lambdageek
[build] Don't download CoreCLR product for Mono runtime tests
99cacd3
Shouldn't be needed after dotnet#62652
Contributes to dotnet#51584, I think
@lambdageeklambdageek mentioned this pull request Dec 14, 2021
Closed
@nariccnaricc mentioned this pull request Dec 14, 2021
Merged
@safern

safern commented Dec 14, 2021

Copy link
Copy Markdown
Member

@naricc we have this: #45521

lambdageek pushed a commit that referenced this pull request Dec 15, 2021
Nathan Ricci
Revert removal of clr dependency from mono builds (#62788)
b635536
This partially reverts this change: #62652
The problem is that although we no longer need to patch, we do need corerun from the clr.hosts subset. Corerun still ends up as part of the pubished clr product artifact, and not in the mono product artifact. And thus we still end up downloading clr, and still need this dependency for now.
@ghostghost locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek left review comments
@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
@safernsafernsafern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make mono runtime tests stop using patching

4 participants

@naricc@lambdageek@safern@jkoritzinsky