Skip to content

Remove small casts on the RHS of ASG(CLS_VAR) - #62693

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
SingleAccretion:Remove-Small-Casts-For-ClsVar-Stores
Dec 19, 2021
Merged

Remove small casts on the RHS of ASG(CLS_VAR)#62693
jakobbotsch merged 1 commit into
dotnet:mainfrom
SingleAccretion:Remove-Small-Casts-For-ClsVar-Stores

Conversation

@SingleAccretion

@SingleAccretionSingleAccretion commented Dec 12, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

CLS_VAR stores have the same truncating semantics as IND stores (they are, in fact, the same in the backend), we can take advantage of that and remove some casts.

This is another change that will help make the deletion of CLS_VAR zero-diff.

Diffs.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 12, 2021
@ghost

ghost commented Dec 12, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

CLS_VAR stores have the same truncating semantics as IND stores (they are, in fact, the same in the backend), we can take advantage of that and remove some casts.

This is another change that will help make the deletion of CLS_VAR zero-diff.

Author:SingleAccretion
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@SingleAccretionSingleAccretion changed the title Remove small casts on the RHS of ASG(CLS_VAR)Remove small casts on the RHS of ASG(CLS_VAR)Dec 12, 2021
@SingleAccretion
SingleAccretion marked this pull request as ready for review December 12, 2021 22:16
@SingleAccretion

SingleAccretion commented Dec 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

jakobbotsch
jakobbotsch approved these changes Dec 19, 2021
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jakobbotsch
jakobbotsch merged commit eca7c43 into dotnet:mainDec 19, 2021
@SingleAccretion
SingleAccretion deleted the Remove-Small-Casts-For-ClsVar-Stores branch December 20, 2021 09:22
@ghostghost locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SingleAccretion@jakobbotsch