[wasm] Testing with NodeJs on CI by pavelsavara · Pull Request #62779 · dotnet/runtime

pavelsavara · 2021-12-14T14:46:24Z

Add WASM test on NodeJS on CI

new job for scenario wasmtestonnodejs in runtime-manual pipeline
wasm CI image bumped to webassembly-20210707133424-12f133e with NodeJs upgrade

RunScript improvements

unified unix and cmd WasmRunnerTemplate
added SetScriptCommands early in the script templates
so that the XHarness defaulting logic could happen on Helix based on current SCENARIO and JS_ENGINE env variables

SendToHelixHelp

WasmTestOnNodeJs scenario triggers NeedsEMSDKNode
NeedsEMSDKNode would take emscripten NodeJs binaries and push it as HelixCorrelationPayload
because NodeJs version on Helix agent is obsolete

Fixes#47336
Fixes#41861
Fixes#62901

ghost · 2021-12-14T14:46:27Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

ghost · 2021-12-14T14:46:44Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Only in runtime-manual pipeline

Author:	pavelsavara
Assignees:	-
Labels:	`arch-wasm`, `area-Build-mono`
Milestone:	-

pavelsavara · 2021-12-14T14:47:09Z

/azp run runtime-manual

azure-pipelines · 2021-12-14T14:47:21Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-14T16:59:33Z

/azp run runtime-manual

azure-pipelines · 2021-12-14T16:59:45Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-14T18:07:02Z

/azp run runtime-manual

azure-pipelines · 2021-12-14T18:07:16Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-14T18:27:41Z

/azp run runtime-manual

azure-pipelines · 2021-12-14T18:27:52Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-15T06:41:54Z

/azp run runtime-manual

azure-pipelines · 2021-12-15T06:42:05Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-15T10:17:28Z

/azp run runtime-manual

azure-pipelines · 2021-12-15T10:17:39Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-15T11:34:20Z

/azp run runtime-manual

azure-pipelines · 2021-12-15T11:34:31Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-15T12:51:29Z

/azp run runtime-manual

azure-pipelines · 2021-12-15T12:51:46Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-15T18:03:32Z

/azp run runtime-manual

azure-pipelines · 2021-12-15T18:03:43Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-16T08:55:55Z

/azp run runtime-manual

pavelsavara · 2021-12-17T13:20:43Z

/azp run runtime-manual

azure-pipelines · 2021-12-17T13:20:57Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-17T15:31:11Z

/azp run runtime-manual

azure-pipelines · 2021-12-17T15:31:25Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-17T17:07:48Z

/azp run runtime-manual

azure-pipelines · 2021-12-17T17:08:03Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-17T20:15:24Z

There are unrelated failing Debugger tests [wasm] debuger test failures on CI #62964
There is new NodeJs failing test System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 test failed #62965 on runtime-manual pipeline
There are lot of unrelated failures on other platforms on runtime-manual and runtime-staging pipelines

radekdoulik

LGTM. It would be nice to have activeissue set on the nodejs failing tests.

pavelsavara · 2021-12-17T21:12:51Z

/azp run runtime-manual

azure-pipelines · 2021-12-17T21:13:05Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2021-12-17T22:07:00Z

/azp run runtime-manual

azure-pipelines · 2021-12-17T22:07:13Z

Azure Pipelines successfully started running 1 pipeline(s).

Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set. Fixes change in the dotnet#62779.

Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set. Fixes change in the #62779.

pavelsavara requested review from maraf, radekdoulik and radical December 14, 2021 14:46

pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Dec 14, 2021

pavelsavara added this to the 7.0.0 milestone Dec 14, 2021

pavelsavara force-pushed the wasm_node_ci branch from 359fe47 to bcedca9Compare December 15, 2021 06:41

pavelsavara force-pushed the wasm_node_ci branch from bcedca9 to 50a4298Compare December 15, 2021 10:17

pavelsavara force-pushed the wasm_node_ci branch from 79a562f to 69b8d73Compare December 16, 2021 08:55

fix
0d0ad45

fix
97d04b2

pavelsavara requested a review from marek-safar as a code owner December 17, 2021 15:30

radekdoulik reviewed Dec 17, 2021
View reviewed changes

Comment threadeng/testing/WasmRunnerTemplate.cmd Outdated

radekdoulik reviewed Dec 17, 2021
View reviewed changes

Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/data/RunScriptTemplate.cmd Outdated

marafand others added 2 commits December 17, 2021 17:59

Fix task marshal tests.
941ca2b

feedback
da5f16d

pavelsavara requested a review from radekdoulik December 17, 2021 20:03

radekdoulik approved these changes Dec 17, 2021
View reviewed changes

pavelsavara added 2 commits December 17, 2021 21:21

active issue
31530a3

feedback
c486656

fix
e1e1b9a

pavelsavara merged commit a73d44f into dotnet:mainDec 18, 2021

maraf added a commit to maraf/runtime that referenced this pull request Jan 4, 2022
Fix running WASM tests locally on Windows.
39f9930
Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set. Fixes change in the dotnet#62779.

maraf mentioned this pull request Jan 4, 2022
Fix running WASM tests locally on Windows #63334
Merged

pavelsavara deleted the wasm_node_ci branch January 4, 2022 13:05

maraf added a commit that referenced this pull request Jan 5, 2022
Fix running WASM tests locally on Windows (#63334)
cab2fd8
Set BROWSER_PATH variable only when HELIX_CORRELATION_PAYLOAD variable is set. Fixes change in the #62779.

rzikm mentioned this pull request Jan 17, 2022
Fix generating RunTests.sh and RunTests.cmd scripts #63875
Merged

ghost locked as resolved and limited conversation to collaborators Feb 3, 2022

Uh oh!

Conversation

pavelsavara commented Dec 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add WASM test on NodeJS on CI

RunScript improvements

SendToHelixHelp

Uh oh!

ghost commented Dec 14, 2021

Uh oh!

ghost commented Dec 14, 2021

Uh oh!

pavelsavara commented Dec 14, 2021

Uh oh!

azure-pipelinesBot commented Dec 14, 2021

Uh oh!

pavelsavara commented Dec 14, 2021

Uh oh!

azure-pipelinesBot commented Dec 14, 2021

Uh oh!

pavelsavara commented Dec 14, 2021

Uh oh!

azure-pipelinesBot commented Dec 14, 2021

Uh oh!

pavelsavara commented Dec 14, 2021

Uh oh!

azure-pipelinesBot commented Dec 14, 2021

Uh oh!

pavelsavara commented Dec 15, 2021

Uh oh!

azure-pipelinesBot commented Dec 15, 2021

Uh oh!

pavelsavara commented Dec 15, 2021

Uh oh!

azure-pipelinesBot commented Dec 15, 2021

Uh oh!

pavelsavara commented Dec 15, 2021

Uh oh!

azure-pipelinesBot commented Dec 15, 2021

Uh oh!

pavelsavara commented Dec 15, 2021

Uh oh!

azure-pipelinesBot commented Dec 15, 2021

Uh oh!

pavelsavara commented Dec 15, 2021

Uh oh!

azure-pipelinesBot commented Dec 15, 2021

Uh oh!

pavelsavara commented Dec 16, 2021

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

azure-pipelinesBot commented Dec 17, 2021

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

azure-pipelinesBot commented Dec 17, 2021

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

azure-pipelinesBot commented Dec 17, 2021

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

radekdoulik left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

azure-pipelinesBot commented Dec 17, 2021

Uh oh!

pavelsavara commented Dec 17, 2021

Uh oh!

azure-pipelinesBot commented Dec 17, 2021

Uh oh!

Reviewers

Assignees

Labels

pavelsavara commented Dec 14, 2021•
edited
Loading