Skip to content

Make ControlFlowBuilder.Clear public. - #62811

Merged
buyaa-n merged 2 commits into
dotnet:mainfrom
teo-tsirpanis:controlflowbuilder-clear
Dec 15, 2021
Merged

Make ControlFlowBuilder.Clear public.#62811
buyaa-n merged 2 commits into
dotnet:mainfrom
teo-tsirpanis:controlflowbuilder-clear

Conversation

@teo-tsirpanis

@teo-tsirpanisteo-tsirpanis commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

This PR makes the System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Clear() method public, as just approved. I also added a test that reuses a ControlFlowBuilder.

Fixes#58765

@ghost

ghost commented Dec 14, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added area-System.Reflection.Metadata new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Dec 14, 2021
@ghost

ghost commented Dec 14, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR makes the System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Clear() method public, as just approved. I also added a test that reuses a ControlFlowBuilder.

Fixes #58765

Author:teo-tsirpanis
Assignees:-
Labels:

area-System.Reflection.Metadata, new-api-needs-documentation

Milestone:-

buyaa-n
buyaa-n approved these changes Dec 14, 2021
View reviewed changes

@buyaa-nbuyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

deeprobin
deeprobin approved these changes Dec 15, 2021
View reviewed changes

@deeprobindeeprobin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teo-tsirpanis
teo-tsirpanisforce-pushed the controlflowbuilder-clear branch from 1fdb940 to 303bdaaCompareDecember 15, 2021 07:18
@buyaa-n
buyaa-n merged commit 6845361 into dotnet:mainDec 15, 2021
@teo-tsirpanis
teo-tsirpanis deleted the controlflowbuilder-clear branch December 15, 2021 22:13
@ghostghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stevehartersteveharterAwaiting requested review from steveharter
@tmattmatAwaiting requested review from tmat
2 more reviewers
@deeprobindeeprobindeeprobin approved these changes
@buyaa-nbuyaa-nbuyaa-n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Reflection.Metadatacommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add System.Reflection.Metadata.Ecma335.ControlFlowBuilder.Reset.

4 participants

@teo-tsirpanis@deeprobin@buyaa-n@joperezr