Skip to content

IL cleanup - remove .module and make .assembly match source name - #62812

Merged
trylek merged 1 commit into
dotnet:mainfrom
trylek:ILModuleAssembly
Dec 15, 2021
Merged

IL cleanup - remove .module and make .assembly match source name#62812
trylek merged 1 commit into
dotnet:mainfrom
trylek:ILModuleAssembly

Conversation

@trylek

@trylektrylek commented Dec 14, 2021

Copy link
Copy Markdown
Member

/cc @dotnet/jit-contrib

@trylektrylek added the area-Infrastructure-coreclr Only use for closed issues label Dec 14, 2021
@ghost

ghost commented Dec 14, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

/cc @dotnet/jit-contrib

Author:trylek
Assignees:-
Labels:

area-Infrastructure-coreclr

Milestone:-

@trylek

trylek commented Dec 14, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@ghostghost assigned trylekDec 14, 2021
@azure-pipelines

azure-pipelinesBot commented Dec 14, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkoritzinsky
jkoritzinsky approved these changes Dec 15, 2021
View reviewed changes

@jkoritzinskyjkoritzinsky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trylek
trylek merged commit 462c292 into dotnet:mainDec 15, 2021
@trylek
trylek deleted the ILModuleAssembly branch December 15, 2021 01:15
@BruceForstall

BruceForstall commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

Question: all these cleanups are nice. Will newly written tests be required to follow all the cleanup "rules"?

@trylek

trylek commented Dec 15, 2021

Copy link
Copy Markdown
MemberAuthor

@BruceForstall - we'll definitely need to add documentation describing the new testing model in more detail. Once all tests have been converted to the new merged wrapper model, authoring a new ILPROJ test will require applying the three transformations (removing .module, making sure .assembly matches the file and adding the [Fact] attribute on main), otherwise the test simply won't work (the Roslyn source generator cannot locate its entrypoint).

@ghostghost locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinskyjkoritzinskyjkoritzinsky approved these changes
+1 more reviewer
@BruceForstallBruceForstallBruceForstall approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@trylektrylek

Labels

area-Infrastructure-coreclrOnly use for closed issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek@BruceForstall@jkoritzinsky