Skip to content

[release/6.0] [wasm][debugger] Avoiding assert on mono runtime - #62816

Merged
safern merged 1 commit into
dotnet:release/6.0from
thaystg:pr-62601-to-release/6.0
Feb 7, 2022
Merged

[release/6.0] [wasm][debugger] Avoiding assert on mono runtime#62816
safern merged 1 commit into
dotnet:release/6.0from
thaystg:pr-62601-to-release/6.0

Conversation

@thaystg

Copy link
Copy Markdown
Member

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #62601 to release/6.0

/cc @thaystg

Customer Impact

As VS tries to evaluate a lot of things while hover the mouse on variables while debugging, could be causing assert on runtime in the case of trying to evaluate in a static class that is in a loaded assembly but not added any breakpoint on it.

Testing

Unit tests and manual tests on Blazor.

Risk

Low Risk, only checking the debugId of the assembly and getting the correct one before send to debugger-agent.

Author:thaystg
Assignees:thaystg
Labels:

Servicing-consider, area-Debugger-mono

Milestone:-

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to tactics approval.

@thaystgthaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 20, 2021
@akoeplingerakoeplinger added this to the 6.0.x milestone Jan 18, 2022
@safern
safern merged commit 2299c9f into dotnet:release/6.0Feb 7, 2022
@ghostghost locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thaystg@radical@marek-safar@akoeplinger@danmoseley@safern