Skip to content

Undo breaking change in 6.0 in environment variable configuration prefix support - #62819

Merged
maryamariyan merged 4 commits into
dotnet:mainfrom
maryamariyan:envvar-regression
Dec 16, 2021
Merged

Undo breaking change in 6.0 in environment variable configuration prefix support#62819
maryamariyan merged 4 commits into
dotnet:mainfrom
maryamariyan:envvar-regression

Conversation

@maryamariyan

@maryamariyanmaryamariyan commented Dec 14, 2021

Copy link
Copy Markdown
Contributor

When using environment variable configuration, brings back support for prefix being normalized like it was in dotnet 5.0.

The prefix is expected to use ":" to work (refer to updated tests).

Fixing regression from last release. Revert changes made in https://github.com/dotnet/runtime/pull/42932/files while updating tests to reduce ambiguity.

Fixes#61577

With environment variable configuration provider, undo support for normalizing prefix using double underscore
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

When using environment variable configuration, brings back support for prefix being normalized like it was in dotnet 5.0.

The environment variable prefix should contain : if on Windows, and __ if on Linux. But the prefix is expected to use ":" to work (refer to updated tests).

Fixing regression from last release. Revert changes made in https://github.com/dotnet/runtime/pull/42932/files while updating tests to reduce ambiguity.

Fixes #61577

Author:maryamariyan
Assignees:maryamariyan
Labels:

area-Extensions-Configuration

Milestone:-

@maryamariyan
maryamariyan merged commit 82866ed into dotnet:mainDec 16, 2021
@maryamariyan

Copy link
Copy Markdown
ContributorAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1588873597

@ghostghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change in environment variable configuration prefix support in dotnet 6

2 participants

@maryamariyan@safern