Skip to content

Remove the varargs-based mdarray helper. - #62855

Merged
jkoritzinsky merged 8 commits into
dotnet:mainfrom
jkoritzinsky:mdarr-no-vararg
Dec 16, 2021
Merged

Remove the varargs-based mdarray helper.#62855
jkoritzinsky merged 8 commits into
dotnet:mainfrom
jkoritzinsky:mdarr-no-vararg

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Rename the non-varargs helper to the old name of the varargs helper as it has a better name.

Remove some now-unused varargs-specific macros.

Fixes#62747

Reviewing without whitespace changes is recommended for the changes in the JIT.

Rename the nonvarargs one to the old name of the varargs-based helper as it has the better name.
@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr crossgen2 outerloop

@dotnetdotnet deleted a comment from azure-pipelinesBotDec 15, 2021
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@VSadov

Copy link
Copy Markdown
Member

I think the change should also re-enable TestGenericMDArrayBehavior test on OSX

@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

Linux_musl ARM test failure is #62873 (I made the criterion for the tracking issue too fine-grained and missed the musl instances of the failure)

@VSadovVSadov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!!

Comment threaddocs/design/coreclr/botr/readytorun-format.md Outdated

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkoritzinsky
jkoritzinsky merged commit 562d1e7 into dotnet:mainDec 16, 2021
@jkoritzinsky
jkoritzinsky deleted the mdarr-no-vararg branch December 16, 2021 23:11
@ghostghost locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constructing MD arrays in R2R code does not work on OSX/ARM64

4 participants

@jkoritzinsky@VSadov@jkotas@jakobbotsch