Skip to content

[Test] Collapse mono runtime tests into single builds using global-build-job template - #62863

Merged
naricc merged 7 commits into
dotnet:mainfrom
naricc:naricc/runtime-global-run
Nov 19, 2022
Merged

[Test] Collapse mono runtime tests into single builds using global-build-job template#62863
naricc merged 7 commits into
dotnet:mainfrom
naricc:naricc/runtime-global-run

Conversation

@naricc

@nariccnaricc commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

I am reviving this PR from a while ago.

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

There were a few tests that didn't run successfully with out the coreclr build for different reasons; I have excluded them in issues.targets for now and will investigate them individually as a follow up item.

mono-windows is still using the old path while I investigate some errors in the build.cmd script.

Contributes to: #45521

This PR only changes the ones in the runtime pipeline. Follow up PRs will change runtime-staging.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

Contributes to: #45521

Draft while I iron out issues in CI.

Author:naricc
Assignees:-
Labels:

area-Infrastructure

Milestone:-

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines failed to run 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines failed to run 1 pipeline(s).

@nariccnaricc closed this Dec 20, 2021
@nariccnaricc reopened this Dec 20, 2021
@naricc

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-manual

@naricc
nariccforce-pushed the naricc/runtime-global-run branch from e71cf46 to 8d7ce1dCompareJanuary 10, 2022 21:05
@naricc
naricc requested a review from imhameedJanuary 12, 2022 20:18
@nariccnaricc changed the title [Draft][Mono][Test] Collapse mono runtime tests into single builds using global-build-job template[Mono][Test] Collapse mono runtime tests into single builds using global-build-job templateJan 21, 2022
@naricc
naricc marked this pull request as ready for review January 21, 2022 16:54
@naricc
nariccforce-pushed the naricc/runtime-global-run branch 2 times, most recently from 9df2172 to 0afa6b9CompareJanuary 26, 2022 00:16
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR changes the way mono is build and consumed for runtime test lanes. Instead of separate steps that build and publish artifacts, and other steps that download them, building and running will be done on one machine.

This reduces the number of network connections required run the tests, and each of those is a potential source of failure. It does preclude the ability to share some build artifacts, but mono builds are fast.

It also lets use remove the coreclr dependency on the effected mono lanes.

Contributes to: #45521

Draft while I iron out issues in CI. Also only moving hte osx_x64 lane for testing purposes.

Author:naricc
Assignees:naricc
Labels:

area-Infrastructure-mono

Milestone:-

@naricc
nariccforce-pushed the naricc/runtime-global-run branch from 3672749 to 5d1b06aCompareMay 6, 2022 18:46
@SamMonoRT

Copy link
Copy Markdown
Member

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@naricc
nariccforce-pushed the naricc/runtime-global-run branch from 149aee5 to 27573d9CompareJuly 15, 2022 17:05
@naricc
naricc requested a review from radical as a code ownerJuly 15, 2022 17:05
@runfoapprunfoappBot mentioned this pull request Jul 15, 2022
radical
radical previously requested changes Jul 15, 2022
Comment threadeng/pipelines/runtime.yml Outdated
Comment threadeng/pipelines/runtime.yml Outdated
Comment threadeng/pipelines/runtime.yml Outdated
Comment threadeng/pipelines/runtime.yml Outdated
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 15, 2022
@naricc
naricc marked this pull request as draft July 18, 2022 17:36
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from azure-pipelinesBotNov 18, 2022
@dotnetdotnet deleted a comment from Universal2313Nov 18, 2022
Comment threadeng/pipelines/common/global-build-job.yml Outdated

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a few nits, thank you!

@naricc
naricc dismissed radical’s stale reviewNovember 18, 2022 20:33

Outdated change requests on old draft

@naricc

Copy link
Copy Markdown
ContributorAuthor

Failures seem spurious.

@naricc
naricc merged commit fe2e4e4 into dotnet:mainNov 19, 2022
@ghostghost locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@naricc@SamMonoRT@radical@trylek@safern@jeffschwMSFT