Skip to content

setInternalRegsDelayFree only for candidate lclVars - #62884

Merged
kunalspathak merged 1 commit into
dotnet:mainfrom
kunalspathak:delayregsfree
Dec 17, 2021
Merged

setInternalRegsDelayFree only for candidate lclVars#62884
kunalspathak merged 1 commit into
dotnet:mainfrom
kunalspathak:delayregsfree

Conversation

@kunalspathak

Copy link
Copy Markdown
Contributor

In #58914 , we partially fixed the #58899, but it should have taken into account it only for candidate lclVars. Without this, we would end up having a delayFree on last use and when we see the new refposition, we would assert because there was a pending delayRegFree without reference.

Fixes: #61579

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 16, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

In #58914 , we partially fixed the #58899, but it should have taken into account it only for candidate lclVars. Without this, we would end up having a delayFree on last use and when we see the new refposition, we would assert because there was a pending delayRegFree without reference.

Fixes: #61579

Author:kunalspathak
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr jitstress-isas-x86

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr jitstressregs-x86

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr jitstress-isas-arm

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr jitstressregs

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@kunalspathak
kunalspathak merged commit a3aec10 into dotnet:mainDec 17, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure Interop\\PInvoke\\Vector2_3_4\\Vector2_3_4\\Vector2_3_4.cmd

2 participants

@kunalspathak@BruceForstall