Skip to content

[wasm] Tweak set timeout - #62898

Merged
maraf merged 2 commits into
dotnet:mainfrom
maraf:WasmTweakSetTimeout
Dec 22, 2021
Merged

[wasm] Tweak set timeout#62898
maraf merged 2 commits into
dotnet:mainfrom
maraf:WasmTweakSetTimeout

Conversation

@maraf

Copy link
Copy Markdown
Member
  • Cache method lookup for TimerQueue.TimeoutCallback and ThreadPool.Callback.
  • Remove unused parameter "id" from timer related functions.

@marafmaraf added the arch-wasm WebAssembly architecture label Dec 16, 2021
@marafmaraf added this to the 7.0.0 milestone Dec 16, 2021
@ghostghost added the area-VM-meta-mono label Dec 16, 2021
@ghostghost assigned marafDec 16, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Cache method lookup for TimerQueue.TimeoutCallback and ThreadPool.Callback.
  • Remove unused parameter "id" from timer related functions.
Author:maraf
Assignees:-
Labels:

arch-wasm

Milestone:7.0.0

@maraf

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maraf
maraf requested review from kg and pavelsavaraDecember 16, 2021 18:53
@maraf

Copy link
Copy Markdown
MemberAuthor

Some tests are failing. I'm not sure it's caused by my changes.

Comment threadsrc/mono/wasm/runtime/scheduling.ts
@maraf

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-manual

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@maraf
maraf merged commit 6f2fa80 into dotnet:mainDec 22, 2021
@maraf
maraf deleted the WasmTweakSetTimeout branch December 22, 2021 09:45
@ghostghost locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-VM-meta-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@maraf@kg@pavelsavara@lambdageek