Uh oh!
There was an error while loading. Please reload this page.
[tests] Cleanup copy/pasted assembly update test projects - #62970
Merged
lambdageek merged 2 commits intoDec 22, 2021
Conversation
ghost
commented
Dec 17, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsReduce the clutter in the .csproj file Compute the Should be no functional change.
|
lambdageekforce-pushed
the
refactor-apply-update-tests-csproj
branch
from
December 17, 2021 20:25
065f856 to
c148a26Compareimhameed
approved these changes
Dec 21, 2021
lambdageek
marked this pull request as draft
December 21, 2021 15:48
lambdageek
commented
Dec 21, 2021
MemberAuthor
Got some feedback offline: I'm going to rewrite this so that the full .csproj names for ProjectReferences are more easily discoverable |
It's easier to grep and it's easier for the IDE to display them Compute the TrimmerRootAssembly items from the project referferences So to add a new test you just need to add a ProjectReference in one place
lambdageekforce-pushed
the
refactor-apply-update-tests-csproj
branch
from
December 21, 2021 16:34
be15fe2 to
7914855Comparelambdageek
marked this pull request as ready for review
December 21, 2021 17:01
lambdageek
commented
Dec 21, 2021
MemberAuthor
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the clutter in the .csproj file
Compute the
ProjectReferenceandTrimmerRootAssemblyitems from a single<ApplyUpdateTest>item instead of doing a lot of copy-pasting.Should be no functional change.