Skip to content

[API Implementation]: Expose AppContext.SetData in ref assembly - #62996

Merged
jkotas merged 10 commits into
dotnet:mainfrom
deeprobin:issue-47922
Dec 21, 2021
Merged

[API Implementation]: Expose AppContext.SetData in ref assembly#62996
jkotas merged 10 commits into
dotnet:mainfrom
deeprobin:issue-47922

Conversation

@deeprobin

@deeprobindeeprobin commented Dec 19, 2021

Copy link
Copy Markdown
Contributor

Proposal implementation of #47922 (closes#47922)

Proposal

namespaceSystem{publicstaticpartialclassAppContext{publicstaticvoidSetData(stringname,object?data);}}

/cc @jkotas
/cc @tannergooding

@ghost

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Dec 19, 2021
@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas

Copy link
Copy Markdown
Member

Could you please also add a few tests and add doc comment on the implementation?

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Proposal implementation of #47922

Proposal

namespaceSystem{publicstaticpartialclassAppContext{publicstaticvoidSetData(stringname,object?data);}}

/cc @jkotas
/cc @tannergooding

Author:deeprobin
Assignees:-
Labels:

area-System.Runtime, new-api-needs-documentation, community-contribution

Milestone:-

@danmoseley

Copy link
Copy Markdown
Contributor

Oh, still needs doc comment on implementation

@deeprobin

Copy link
Copy Markdown
ContributorAuthor

Oh, still needs doc comment on implementation

incoming :)

@deeprobin

Copy link
Copy Markdown
ContributorAuthor

Oh, still needs doc comment on implementation

Done.

@danmoseley I saw also, that GetData has no documentation comment (but in API Docs this is present - https://docs.microsoft.com/en-us/dotnet/api/system.appcontext.getdata?view=net-6.0)
If you want to document GetData afterwards, you can create a new issue regarding this 👍🏼

Comment threadsrc/libraries/System.Runtime/tests/System.Runtime.Tests.csproj Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/AppContext/AppContext.cs Outdated
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@jkotas

Copy link
Copy Markdown
Member

GetData has no documentation comment (but in API Docs this is present -

We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this.

@deeprobin

Copy link
Copy Markdown
ContributorAuthor

GetData has no documentation comment (but in API Docs this is present -

We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this.

Perfect 👍🏼

Comment threadsrc/libraries/System.Runtime/tests/System/AppContext/AppContext.cs Outdated
deeprobinand others added 4 commits December 20, 2021 20:24
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@jkotas
jkotas merged commit 6a9bfee into dotnet:mainDec 21, 2021
@deeprobindeeprobin changed the title Expose AppContext.SetData in ref assembly[API Implementation]: Expose AppContext.SetData in ref assemblyJan 20, 2022
@ghostghost locked as resolved and limited conversation to collaborators Feb 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtimecommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: AppContext.SetData

3 participants

@deeprobin@jkotas@danmoseley