Uh oh!
There was an error while loading. Please reload this page.
[API Implementation]: Expose AppContext.SetData in ref assembly - #62996
Conversation
ghost
commented
Dec 19, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Dec 19, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
commented
Dec 19, 2021
Could you please also add a few tests and add doc comment on the implementation? |
ghost
commented
Dec 19, 2021
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsProposal implementation of #47922 ProposalnamespaceSystem{publicstaticpartialclassAppContext{publicstaticvoidSetData(stringname,object?data);}}/cc @jkotas
|
danmoseley
commented
Dec 20, 2021
Oh, still needs doc comment on implementation |
deeprobin
commented
Dec 20, 2021
incoming :) |
deeprobin
commented
Dec 20, 2021
Done. @danmoseley I saw also, that |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Uh oh!
There was an error while loading. Please reload this page.
jkotas
commented
Dec 20, 2021
We have a dedicate project to add the documentation comments to all old APIs. No need to file an issue on this. |
deeprobin
commented
Dec 20, 2021
Perfect 👍🏼 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Proposal implementation of #47922 (closes#47922)
Proposal
/cc @jkotas
/cc @tannergooding