Skip to content

LoggingHttpMessageHandler should log unescaped URL in log message (#62894) - #63012

Merged
CarnaViire merged 1 commit into
dotnet:mainfrom
antmeehan:users/meehana/http-logging-62894
Jan 11, 2022
Merged

LoggingHttpMessageHandler should log unescaped URL in log message (#62894)#63012
CarnaViire merged 1 commit into
dotnet:mainfrom
antmeehan:users/meehana/http-logging-62894

Conversation

@antmeehan

@antmeehanantmeehan commented Dec 20, 2021

Copy link
Copy Markdown
Contributor

Modifies the logging in LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged.

Fix#62894

@ghostghost added area-Extensions-HttpClientFactory community-contribution Indicates that the PR has been added by a community member labels Dec 20, 2021
@ghost

ghost commented Dec 20, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Modifies the logging in LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged.

Fix #62894

Author:antmeehan
Assignees:-
Labels:

area-Extensions-HttpClientFactory

Milestone:-

@dnfadmin

dnfadmin commented Dec 20, 2021•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@antmeehanantmeehan mentioned this pull request Dec 20, 2021
Closed
MihaZupan
MihaZupan reviewed Dec 20, 2021
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs Outdated
@antmeehan
antmeehanforce-pushed the users/meehana/http-logging-62894 branch 2 times, most recently from 9f6dde0 to 03e8341CompareDecember 21, 2021 00:25
MihaZupan
MihaZupan reviewed Jan 4, 2022
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Http/src/Logging/LoggingScopeHttpMessageHandler.cs Outdated
Comment threadsrc/libraries/Microsoft.Extensions.Http/src/Logging/LoggingHttpMessageHandler.cs Outdated
@antmeehan
antmeehanforce-pushed the users/meehana/http-logging-62894 branch from 03e8341 to 2fa1722CompareJanuary 10, 2022 13:27
@antmeehan
LoggingHttpMessageHandler should log unescaped URL in log message (do…
212e048
…tnet#62894)
Modifies the logging in LoggingHttpMessageHandler and LoggingScopeHttpMessageHandler to log the AbsoluteUri so the unescaped Uri is logged
@antmeehan
antmeehanforce-pushed the users/meehana/http-logging-62894 branch from 2fa1722 to 212e048CompareJanuary 10, 2022 13:52
MihaZupan
MihaZupan approved these changes Jan 10, 2022
View reviewed changes

@MihaZupanMihaZupan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CarnaViire
CarnaViire approved these changes Jan 11, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CarnaViire
CarnaViire merged commit b8a8c7a into dotnet:mainJan 11, 2022
@antmeehan
antmeehan deleted the users/meehana/http-logging-62894 branch January 12, 2022 12:17
@ghostghost locked as resolved and limited conversation to collaborators Mar 1, 2022
@karelzkarelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@CarnaViireCarnaViireCarnaViire approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes
+1 more reviewer
@gfoidlgfoidlgfoidl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-HttpClientFactorycommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

LoggingHttpMessageHandler should log unescaped URL in log message

6 participants

@antmeehan@dnfadmin@CarnaViire@gfoidl@MihaZupan@karelz