Skip to content

[wasm][debugger] Missing test files - #63148

Merged
akoeplinger merged 1 commit into
dotnet:release/6.0from
thaystg:thays_add_missing_proj
Jan 14, 2022
Merged

[wasm][debugger] Missing test files#63148
akoeplinger merged 1 commit into
dotnet:release/6.0from
thaystg:thays_add_missing_proj

Conversation

@thaystg

@thaystgthaystg commented Dec 27, 2021

Copy link
Copy Markdown
Member

Adding test files that were not added on release 6.0 by mistake.

@ghostghost assigned thaystgDec 27, 2021
@ghost

ghost commented Dec 27, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding test files that were not added on release 6.0 by mistake.

Author:thaystg
Assignees:thaystg
Labels:

area-Debugger-mono

Milestone:-

@thaystg

thaystg commented Dec 27, 2021

Copy link
Copy Markdown
MemberAuthor

@marek-safar Do I need to send an email to tactics for it?

@marek-safarmarek-safar added the Servicing-consider Issue for next servicing release review label Dec 28, 2021
@marek-safarmarek-safar added this to the 6.0.x milestone Dec 28, 2021
@marek-safar

marek-safar commented Dec 28, 2021

Copy link
Copy Markdown
Contributor

@thaystg yes but you can reply to the original approval

@lambdageek

lambdageek commented Jan 4, 2022

Copy link
Copy Markdown
Member

This is the project needed for this test https://github.com/dotnet/runtime/blob/release/6.0/src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs#L864InspectLocalsUsingClassFromLibraryUsingDebugTypeFull ?

@thaystg

thaystg commented Jan 4, 2022

Copy link
Copy Markdown
MemberAuthor

This is the project needed for this test https://github.com/dotnet/runtime/blob/release/6.0/src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs#L864InspectLocalsUsingClassFromLibraryUsingDebugTypeFull ?

Yes

@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 4, 2022
@leecowleecow modified the milestones: 6.0.x, 6.0.2Jan 4, 2022
@akoeplinger
akoeplinger merged commit 6de5c5b into dotnet:release/6.0Jan 14, 2022
@ghostghost locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner

Assignees

@thaystgthaystg

Labels

area-Debugger-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@thaystg@marek-safar@lambdageek@akoeplinger@leecow