Skip to content

Remove unneeded ifdefs - #63160

Merged
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:RemoveUnneededIfdefs
Dec 28, 2021
Merged

Remove unneeded ifdefs#63160
BruceForstall merged 1 commit into
dotnet:mainfrom
BruceForstall:RemoveUnneededIfdefs

Conversation

@BruceForstall

Copy link
Copy Markdown
Contributor

Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.

Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 28, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.

Author:BruceForstall
Assignees:BruceForstall
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib PTAL

@echesakovechesakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No diffs with spmi? Forgot that I can look this myself in the CI:)

@BruceForstall
BruceForstall merged commit 15e95fc into dotnet:mainDec 28, 2021
@BruceForstall
BruceForstall deleted the RemoveUnneededIfdefs branch December 28, 2021 23:22
@ghostghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@BruceForstall@echesakov