Skip to content

Fixing a crash bug - #63222

Merged
jkotas merged 2 commits into
dotnet:mainfrom
masonwheeler:main
Dec 30, 2021
Merged

Fixing a crash bug#63222
jkotas merged 2 commits into
dotnet:mainfrom
masonwheeler:main

Conversation

@masonwheeler

@masonwheelermasonwheeler commented Dec 30, 2021

Copy link
Copy Markdown
Contributor

ILVerify will currently crash with a NullReferenceException if parsing a type signature referring to an assembly that was not specified as a -r parameter.

Fixes#63221.

@ghostghost added area-ReadyToRun community-contribution Indicates that the PR has been added by a community member labels Dec 30, 2021
CyrusNajmabadi
CyrusNajmabadi reviewed Dec 30, 2021
View reviewed changes
Comment threadsrc/coreclr/tools/Common/TypeSystem/Ecma/EcmaModule.cs
@jkotasjkotas added the area-Tools-ILVerification Issues related to ilverify tool and IL verification in general label Dec 30, 2021
@ghost

ghost commented Dec 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

ILVerify will currently crash with a NullReferenceException if parsing a type signature referring to an assembly that was not specified as a -r parameter.

Fixes #63221.

Author:masonwheeler
Assignees:-
Labels:

area-crossgen2-coreclr, area-ILVerification, community-contribution

Milestone:-

@masonwheeler

masonwheeler commented Dec 30, 2021

Copy link
Copy Markdown
ContributorAuthor

Fixes #62711

jkotas
jkotas approved these changes Dec 30, 2021
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
jkotas merged commit d0631be into dotnet:mainDec 30, 2021
@ghostghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky
+1 more reviewer
@CyrusNajmabadiCyrusNajmabadiCyrusNajmabadi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Tools-ILVerificationIssues related to ilverify tool and IL verification in generalcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad data can cause ILVerify to throw NRE

3 participants

@masonwheeler@CyrusNajmabadi@jkotas