Skip to content

Use SAL2 _In_, _Out_ to prevent conflicts. - #63261

Merged
jkotas merged 1 commit into
dotnet:mainfrom
NN---:sal2
Jan 3, 2022
Merged

Use SAL2 _In_, _Out_ to prevent conflicts.#63261
jkotas merged 1 commit into
dotnet:mainfrom
NN---:sal2

Conversation

@NN---

@NN---NN--- commented Jan 2, 2022

Copy link
Copy Markdown
Contributor

Attempt to address #37310

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Jan 2, 2022
@ghost

ghost commented Jan 2, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@NN---NN--- closed this Jan 2, 2022
@NN---NN--- reopened this Jan 2, 2022
@jkotasjkotas added the area-PAL-coreclr only for closed issues label Jan 2, 2022
jkotas
jkotas reviewed Jan 2, 2022
View reviewed changes
Comment threadsrc/coreclr/pal/inc/rt/sal.h Outdated
jkotas
jkotas reviewed Jan 2, 2022
View reviewed changes
Comment threadsrc/coreclr/pal/inc/rt/specstrings_undef.h Outdated
@NN---
NN--- requested a review from jkotasJanuary 3, 2022 06:41
@jkotasjkotas mentioned this pull request Jan 3, 2022
Closed
jkotas
jkotas approved these changes Jan 3, 2022
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice to convert the remaining SAL v1 annotations to SAL v2 annotations for consistency. I have opened #63307 to track it.

@jkotas
jkotas merged commit 9472bfe into dotnet:mainJan 3, 2022
@jkotas

jkotas commented Jan 3, 2022

Copy link
Copy Markdown
Member

@NN--- Thank you!

@NN---
NN--- deleted the sal2 branch January 6, 2022 17:54
@ghostghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner

Assignees

No one assigned

Labels

area-PAL-coreclronly for closed issuescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NN---@jkotas