Skip to content

A few minor tweaks to Regex source generator rendering - #63276

Merged
stephentoub merged 7 commits into
dotnet:mainfrom
stephentoub:tweakrendering
Jan 4, 2022
Merged

A few minor tweaks to Regex source generator rendering#63276
stephentoub merged 7 commits into
dotnet:mainfrom
stephentoub:tweakrendering

Conversation

@stephentoub

@stephentoubstephentoub commented Jan 3, 2022

Copy link
Copy Markdown
Member
  • Rename the FindFirstChar lable from ReturnFalse to NoStartingPositionFound
  • Separate some code in back reference handling with a blank line
  • Make optionals (?) render as "Optional" rather than as "Loop"
  • Avoid "at least 0" in loop descriptions
  • Avoid an unnecessary addition at run-time in EndZ anchor handling

@stephentoubstephentoub added this to the 7.0.0 milestone Jan 3, 2022
@ghost

ghost commented Jan 3, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Rename the FindFirstChar lable from ReturnFalse to NoStartingPositionFound
  • Separate some code in back reference handling with a blank line
  • Make optionals (?) render as "Optional" rather than as "Loop"
  • Avoid "at least 0" in loop descriptions
  • Avoid an unnecessary addition at run-time in EndZ anchor handling
Author:stephentoub
Assignees:-
Labels:

area-System.Text.RegularExpressions, tenet-performance

Milestone:7.0.0

@ghostghost assigned stephentoubJan 3, 2022
joperezr
joperezr reviewed Jan 3, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs Outdated
joperezr
joperezr approved these changes Jan 3, 2022
View reviewed changes

@joperezrjoperezr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub
stephentoub merged commit 80f6845 into dotnet:mainJan 4, 2022
@stephentoub
stephentoub deleted the tweakrendering branch January 4, 2022 01:38
@ghostghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joperezrjoperezrjoperezr approved these changes

Assignees

@stephentoubstephentoub

Labels

area-System.Text.RegularExpressionstenet-performancePerformance related issue

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub@joperezr