Uh oh!
There was an error while loading. Please reload this page.
Fix ABI stress test coverage - #63409
Merged
Merged
Conversation
When this test was changed to use a seed from an environment variable it changed the test to repeatedly create the same Random instance, reducing coverage to only ever test one variant. This reverts the changes by dotnet#50767 and uses the environment variable in the existing seed mechanism instead.
ghost
commented
Jan 5, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWhen this test was changed to use a seed from an environment variable it This reverts the changes by #50767 and uses the environment variable in
|
jakobbotsch
commented
Jan 6, 2022
MemberAuthor
cc @dotnet/jit-contrib |
jakobbotsch
commented
Jan 10, 2022
MemberAuthor
Ping @dotnet/jit-contrib, simple test change |
AndyAyersMS
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this test was changed to use a seed from an environment variable it
changed the test to repeatedly create the same Random instance, reducing
coverage to only ever test one variant.
This reverts the changes by #50767 and uses the environment variable in
the existing seed mechanism instead.