Uh oh!
There was an error while loading. Please reload this page.
[debugger] Fix reading a byte without checking the version of the Protocol - #63503
Conversation
ghost
commented
Jan 7, 2022
Tagging subscribers to this area: @thaystg Issue DetailsShould read this byte only in earlier versions. This is a side-effect of this PR: #52300 I think we should backport to 6.0 or at least to 6.0maui
|
radical
commented
Jan 7, 2022
Does this affect wasm too? If so, then can we add a test there? |
thaystg
commented
Jan 7, 2022
This doesn't affect wasm, because wasm is already using 61 version. |
thaystg
commented
Jan 10, 2022
@lewing should I backport to 6.0 or at least to 6.0maui? |
lambdageek
commented
Jan 11, 2022
/backport to release/6.0-maui |
Started backporting to release/6.0-maui: https://github.com/dotnet/runtime/actions/runs/1682940829 |
@lambdageek backporting to release/6.0-maui failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Should read this byte only in earlier versions.
Using index info to reconstruct a base tree...
M src/mono/mono/component/debugger-agent.c
Falling back to patching base and 3-way merge...
Auto-merging src/mono/mono/component/debugger-agent.c
CONFLICT (content): Merge conflict in src/mono/mono/component/debugger-agent.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Should read this byte only in earlier versions.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
lambdageek
commented
Jan 11, 2022
@thaystg the backport bot failed, you will need to backport by hand |
Should read this byte only in earlier versions.
This can break features while debugging on ios/android.
This is a side-effect of this PR: #52300
I think we should backport to 6.0 or at least to 6.0maui