Skip to content

[wasm][debugger] Add getter properties unfolding in structures. - #63574

Merged
ilonatommy merged 4 commits into
dotnet:mainfrom
ilonatommy:structure-getters-63041
Jan 11, 2022
Merged

[wasm][debugger] Add getter properties unfolding in structures.#63574
ilonatommy merged 4 commits into
dotnet:mainfrom
ilonatommy:structure-getters-63041

Conversation

@ilonatommy

@ilonatommyilonatommy commented Jan 10, 2022

Copy link
Copy Markdown
Member

Fixes#63041.

@ilonatommyilonatommy self-assigned this Jan 10, 2022
@ghost

ghost commented Jan 10, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63041.

Author:ilonatommy
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@ilonatommy
ilonatommy removed the request for review from marek-safarJanuary 10, 2022 11:28
@ilonatommyilonatommy added the arch-wasm WebAssembly architecture label Jan 10, 2022
@ghost

ghost commented Jan 10, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #63041.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@ilonatommyilonatommy added this to the 7.0.0 milestone Jan 10, 2022
@ilonatommyilonatommy changed the title Add getter properties unfolding in structures.[wasm][debugger] Add getter properties unfolding in structures.Jan 10, 2022
ilonatommy
ilonatommy commented Jan 10, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs Outdated
radical
radical reviewed Jan 10, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs Outdated
radical
radical reviewed Jan 10, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DevToolsHelper.cs Outdated
@ilonatommy
ilonatommy merged commit 61d5a4a into dotnet:mainJan 11, 2022
@ilonatommy
ilonatommy deleted the structure-getters-63041 branch January 11, 2022 13:54
radical
radical reviewed Jan 12, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
Comment on lines +1545 to +1546
valueTypes.TryGetValue(objectId, out var valueType);
if (valueType != null)

@radicalradicalJan 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if(valueTypes.TryGetValue(objectId,outvarvalueType))returnawaitInvokeMethod(valueType.valueTypeBuffer,methodId,varName,token);

Try* pattern returns true when the call succeeds, and the out param has a valid value.

radical
radical reviewed Jan 12, 2022
View reviewed changes
Comment threadsrc/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
@ghostghost locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@lambdageeklambdageekAwaiting requested review from lambdageek
@thaystgthaystgAwaiting requested review from thaystg

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[debugger][wasm] Check if Runtime.GetProperties works for structures with getters

3 participants

@ilonatommy@radical@thaystg