Skip to content

Add a few missing Stream overrides - #63579

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:morestreamoverrides
Jan 10, 2022
Merged

Add a few missing Stream overrides#63579
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:morestreamoverrides

Conversation

@stephentoub

Copy link
Copy Markdown
Member

Closes#63191

@ghost

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #63191

Author:stephentoub
Assignees:-
Labels:

area-System.IO.Compression, new-api-needs-documentation

Milestone:-

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stephentoub !

@adamsitnikadamsitnik added this to the 7.0.0 milestone Jan 10, 2022
@stephentoub
stephentoub merged commit c92c767 into dotnet:mainJan 10, 2022
@stephentoub
stephentoub deleted the morestreamoverrides branch January 10, 2022 19:36
@ghostghost locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate that no important Stream overrides are missing based on a systematic check

2 participants

@stephentoub@adamsitnik