Skip to content

[release/6.0] Update zip extraction to never throw any exceptions when the LastWriteTime update fails - #64192

Merged
safern merged 1 commit into
release/6.0from
backport/pr-63912-to-release/6.0
Feb 7, 2022
Merged

[release/6.0] Update zip extraction to never throw any exceptions when the LastWriteTime update fails#64192
safern merged 1 commit into
release/6.0from
backport/pr-63912-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Backport of #63912 to release/6.0

/cc @adamsitnik@EatonZ

Customer Impact

After successful extraction to a file, the file handle is closed. After that, it's opened again to set the last write time. As reported by customer in #63912 some AV software can open it in the meantime and lock the access to the file. As the end result, Windows customers, who have AV software installed can sporadically observe an IOException (ERROR_SHARING_VIOLATION).

Testing

I was not able to reproduce this bug locally and I don't think that it's possible to implement a reliable test for it.

Risk

Can't see any.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #63912 to release/6.0

/cc @adamsitnik@EatonZ

Customer Impact

Testing

Risk

Author:github-actions[bot]
Assignees:-
Labels:

area-System.IO.Compression

Milestone:-

@adamsitnikadamsitnik added the Servicing-consider Issue for next servicing release review label Jan 24, 2022
@leecowleecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 25, 2022
@leecowleecow added this to the 6.0.3 milestone Jan 25, 2022
@EatonZ

Copy link
Copy Markdown
Contributor

I appreciated the approval for a servicing release.👍
When do you think 6.0.3 will release?

@danmoseley

Copy link
Copy Markdown
Contributor

When do you think 6.0.3 will release?

Scheduled for 2nd week of March.

@safern

Copy link
Copy Markdown
Member

Failures are unrelated. System.Text.Json failure is: #61524

Diagnostics failure seems to be a machine in a bad state:

System.InvalidOperationException : Cannot load Counter Name data because an invalid index '' was read from the registry. Performance counters on the machine may need to be repaired.

@safern
safern merged commit 3b0b34c into release/6.0Feb 7, 2022
@safern
safern deleted the backport/pr-63912-to-release/6.0 branch February 7, 2022 19:09
@ghostghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.IO.CompressionServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@EatonZ@danmoseley@safern@adamsitnik@ericstj@leecow