Skip to content

Expand System.Runtime.InteropServices.NFloat to support the APIs required by Xamarin - #64234

Merged
tannergooding merged 7 commits into
dotnet:mainfrom
tannergooding:fix-63801
Jan 28, 2022
Merged

Expand System.Runtime.InteropServices.NFloat to support the APIs required by Xamarin#64234
tannergooding merged 7 commits into
dotnet:mainfrom
tannergooding:fix-63801

Conversation

@tannergooding

@tannergoodingtannergooding commented Jan 24, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This resolves#63801.

Tests still need to be added.

@ghost

ghost commented Jan 24, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tannergooding

tannergooding commented Jan 24, 2022

Copy link
Copy Markdown
MemberAuthor

CC. @rolfbjarne, @marek-safar, @jeffhandley

@tannergoodingtannergooding mentioned this pull request Jan 24, 2022
Closed
rolfbjarne
rolfbjarne requested changes Jan 25, 2022
View reviewed changes

@rolfbjarnerolfbjarne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like two operators are reversed?

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs Outdated
@ghostghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 25, 2022
@tannergooding@rolfbjarne
Apply suggestions from code review
5e25e30
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@ghostghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 25, 2022
@tannergoodingtannergooding mentioned this pull request Jan 27, 2022
Closed
@tannergooding
tannergooding marked this pull request as ready for review January 27, 2022 19:21
stephentoub
stephentoub reviewed Jan 28, 2022
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/NFloat.cs
[NonVersionable]
public static bool operator !=(NFloat left, NFloat right) => left._value != right._value;

/// <summary>Compares two values to determine which is less.</summary>

@stephentoubstephentoubJan 28, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This description seems a bit misleading, as it tells you whether left is less than right but not whether right is strictly less then left.

Consider adopting the existing doc terminology that float/double use, e.g. "Returns a value that indicates whether a specified Double value is less than or equal to another specified Double value."

That goes for all these doc comments.

@tannergoodingtannergoodingJan 28, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adopting the existing doc terminology

I always forget that we have APIs exposed here that are functionally unavailable and will never be called 👍

I'll update this in a follow up PR as I need to also update IComparisonOperators and a few other places accordingly.

stephentoub
stephentoub approved these changes Jan 28, 2022
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a quick skim and generally LGTM.

@tannergoodingtannergooding mentioned this pull request Jan 28, 2022
Closed
@tannergooding
tannergooding merged commit f2538c6 into dotnet:mainJan 28, 2022
@tannergooding

tannergooding commented Jan 31, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1774427144

@github-actionsgithub-actionsBot mentioned this pull request Jan 31, 2022
Merged
@uweiganduweigand mentioned this pull request Jan 31, 2022
Closed
@uweiganduweigand mentioned this pull request Feb 11, 2022
Merged
@ghostghost locked as resolved and limited conversation to collaborators Mar 3, 2022
@tannergooding
tannergooding deleted the fix-63801 branch November 11, 2022 15:30
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rolfbjarnerolfbjarnerolfbjarne approved these changes
@stephentoubstephentoubstephentoub approved these changes

Assignees

@tannergoodingtannergooding

Labels

area-System.Runtime.InteropServicesnew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend System.Runtime.InteropServices.NFloat so it can replace the Xamarin in-box nfloat for .NET 7

3 participants

@tannergooding@rolfbjarne@stephentoub