[wasm] Fix WebSocket tests on NodeJS by maraf · Pull Request #64330 · dotnet/runtime

maraf · 2022-01-26T12:16:38Z

FixesNodeJS packed as correlation payload doesn't preserve symbolic links #64473 - restore two symbolic links.
Add WasmXHarnessArgsCli as an alternative variable that can be used from cli, as WasmXHarnessMonoArgs is used in some csprojs.
Include TestEchoMiddleware and RemoteLoopMiddleware as correlation payload even for NodeJS.
Move SetScriptCommands to a targets so they are in correct order in the generated run script.

ghost · 2022-01-26T12:16:44Z

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Move all SetScriptCommands for NPM restore to a target, so they are placed after scenario in the generated script.
Fix passing WasmXHarnessMonoArgs. The original where passed to XHarness, but not to the javascript.

Author:	maraf
Assignees:	maraf
Labels:	`arch-wasm`, `area-Infrastructure-mono`
Milestone:	-

maraf · 2022-01-26T12:17:05Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-26T12:17:24Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-01-27T14:12:38Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-27T14:12:59Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-01-27T20:29:21Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-01-27T20:29:40Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-01-28T10:31:14Z

Perhaps unrelated, but why we have WasmXHarnessArgs into _XHarnessArgs

and then both _XHarnessArgs and WasmXHarnessArgs into RunScriptCommand

Does that duplicate WasmXHarnessArgs ?

Also, could we improve it so that I could pass something like /p:WasmXHarnessArgs="--no-headless" from commandline without ruining --web-server-use-cors by forcing WasmXHarnessArgs to constant.

maraf · 2022-01-28T13:20:15Z

Perhaps unrelated, but why we have WasmXHarnessArgs into _XHarnessArgs
and then both _XHarnessArgs and WasmXHarnessArgs into RunScriptCommand

There are two flavors of those - MSBuild property vs environment variable. I have added a comment about it.

Also, could we improve it so that I could pass something like /p:WasmXHarnessArgs="--no-headless" from commandline without ruining --web-server-use-cors by forcing WasmXHarnessArgs to constant.

I have add a new MSBuild property WasmXHarnessArgsCli that behaves as WasmXHarnessArgs, but it's used in csprojs.

maraf · 2022-02-03T16:03:11Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-03T16:03:33Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-03T18:05:56Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-03T18:06:19Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-04T08:20:50Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-04T08:21:11Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-04T09:54:08Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-04T09:54:33Z

Azure Pipelines successfully started running 1 pipeline(s).

…ario in the generated script. Fix passing WasmXHarnessMonoArgs. The original where passed to XHarness, but not to the javascript.

maraf · 2022-02-08T11:22:51Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-08T11:23:11Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-08T13:44:11Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-08T13:44:33Z

Azure Pipelines successfully started running 1 pipeline(s).

…deJS.

maraf · 2022-02-08T16:22:30Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-08T16:22:55Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-08T16:32:08Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-08T16:32:29Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-02-08T16:41:11Z

/azp run runtime-extra-platforms

azure-pipelines · 2022-02-08T16:41:37Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Jan 26, 2022

maraf self-assigned this Jan 26, 2022

maraf added this to the 7.0.0 milestone Jan 26, 2022

maraf requested review from pavelsavara and radical January 28, 2022 07:46

radical reviewed Jan 28, 2022
View reviewed changes

Comment threadsrc/libraries/sendtohelix-wasm.targets Outdated

maraf mentioned this pull request Jan 28, 2022
NodeJS packed as correlation payload doesn't preserve symbolic links #64473
Closed

maraf force-pushed the WasmFixWebSocketTestsOnNodeJs branch from 5766f80 to 1680cbeCompare February 3, 2022 13:42

This was referenced Feb 3, 2022
normal-system.text.json.sourcegeneration.roslyn3.11.unit.tests work item #64762
Closed
system.globalization.tests.icutests.icushouldbeloaded #64763
Closed

maraf mentioned this pull request Feb 4, 2022
[wasm] Fix scenario specific tests #64800
Merged

Move all SetScriptCommands to a target, so they are placed after scen…
c293b57
…ario in the generated script. Fix passing WasmXHarnessMonoArgs. The original where passed to XHarness, but not to the javascript.

Delete npm and npx and recreate symbolic links manually.
5fe7c0f

maraf force-pushed the WasmFixWebSocketTestsOnNodeJs branch from 6c75fce to 5fe7c0fCompare February 8, 2022 11:22

Fix and split command.
ac6285c

maraf added 2 commits February 8, 2022 17:20

Copy TestEchoMiddleware and RemoteLoopMiddleware even for Scenario=No…
5f83a8e
…deJS.

Split commands per item.
83660c0

maraf requested a review from radical February 8, 2022 16:23

maraf marked this pull request as ready for review February 8, 2022 16:23

Comments.
0cf039a

maraf added 2 commits February 8, 2022 17:39

Drop transporting node as tar, as we still restore sym links manually.
d465a5d

Drop extra spaces.
e7a9d7b

runfoappBot mentioned this pull request Feb 8, 2022
WasmTestOnNodeJs-System.Threading.Channels.Tests failing with 'RuntimeError: invalid index into function table' #65016
Closed

pavelsavara approved these changes Feb 8, 2022
View reviewed changes

maraf merged commit 1ac45f5 into dotnet:mainFeb 9, 2022

maraf deleted the WasmFixWebSocketTestsOnNodeJs branch February 9, 2022 09:27

ghost locked as resolved and limited conversation to collaborators Mar 11, 2022

Uh oh!

Conversation

maraf commented Jan 26, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 26, 2022

Uh oh!

maraf commented Jan 26, 2022

Uh oh!

azure-pipelinesBot commented Jan 26, 2022

Uh oh!

maraf commented Jan 27, 2022

Uh oh!

azure-pipelinesBot commented Jan 27, 2022

Uh oh!

maraf commented Jan 27, 2022

Uh oh!

azure-pipelinesBot commented Jan 27, 2022

Uh oh!

pavelsavara commented Jan 28, 2022

Uh oh!

maraf commented Jan 28, 2022

Uh oh!

Uh oh!

maraf commented Feb 3, 2022

Uh oh!

azure-pipelinesBot commented Feb 3, 2022

Uh oh!

maraf commented Feb 3, 2022

Uh oh!

azure-pipelinesBot commented Feb 3, 2022

Uh oh!

maraf commented Feb 4, 2022

Uh oh!

azure-pipelinesBot commented Feb 4, 2022

Uh oh!

maraf commented Feb 4, 2022

Uh oh!

azure-pipelinesBot commented Feb 4, 2022

Uh oh!

maraf commented Feb 8, 2022

Uh oh!

azure-pipelinesBot commented Feb 8, 2022

Uh oh!

maraf commented Feb 8, 2022

Uh oh!

azure-pipelinesBot commented Feb 8, 2022

Uh oh!

maraf commented Feb 8, 2022

Uh oh!

azure-pipelinesBot commented Feb 8, 2022

Uh oh!

maraf commented Feb 8, 2022

Uh oh!

azure-pipelinesBot commented Feb 8, 2022

Uh oh!

maraf commented Feb 8, 2022

Uh oh!

azure-pipelinesBot commented Feb 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maraf commented Jan 26, 2022•
edited
Loading