Uh oh!
There was an error while loading. Please reload this page.
Copy propagation tweaking - #64378
Merged
AndyAyersMS merged 4 commits intoFeb 10, 2022
Merged
Conversation
ghost
commented
Jan 27, 2022
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsSome small CQ improvements in preparation for a zero-diff TP-oriented refactoring.
|
SingleAccretion
marked this pull request as ready for review
January 27, 2022 15:51
SingleAccretion
commented
Jan 27, 2022
ContributorAuthor
@dotnet/jit-contrib |
The type check is too conservative: it prevents partial
definitions from being used in propagation:
```
LCL_FLD V00/1 [X] = { ... }; // Pushed on the stack as a def.
USE LCL_VAR V01 // Has the same VN as V00/1, but the type
// check prevented it from being replaced.
```
This new version is conservative too, but will do for now
as we don't propagate on (most) partial uses.
Another reason for this change is that in my upcoming refactoring
of copy propagation (that will bring another 0.5% in TP gains), we
will no longer have the "defNode" available.Ordinarily, shadowed parameters would not be used for propagation anyway, because of the liveness check, but "this" bypasses that checks, and so was used, which is presumably not what we want. Regardless of that, it is also not profitable to propagate "this" in such a situation as it extends its live range and makes the RA unhappy.
SingleAccretionforce-pushed
the
Copy-Propagation-Checks
branch
from
February 5, 2022 18:03
873f338 to
f7be01cCompare| public: | ||
| struct ShadowParamVarInfo | ||
| { | ||
| static const unsigned NO_SHADOW_COPY = UINT_MAX; |
Member
There was a problem hiding this comment.
Nit: why not just use BAD_VAR_NUM?
ContributorAuthor
There was a problem hiding this comment.
I suppose no reason. Deleted it.
AndyAyersMS
approved these changes
Feb 10, 2022
AndyAyersMS
left a comment
Member
There was a problem hiding this comment.
Thanks again for your ongoing contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small CQ improvements in preparation for a zero-diff TP-oriented refactoring.
Please refer to the individual commit messages for details.
Diffs.