Skip to content

Temporarily disable EC file import tests - #64397

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
bartonjs:avoid_cng_lockup
Jan 27, 2022
Merged

Temporarily disable EC file import tests#64397
stephentoub merged 1 commit into
dotnet:mainfrom
bartonjs:avoid_cng_lockup

Conversation

@bartonjs

@bartonjsbartonjs commented Jan 27, 2022

Copy link
Copy Markdown
Member

Mitigates #64389

@ghostghost assigned bartonjsJan 27, 2022
@ghost

ghost commented Jan 27, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Mitigates #64389

Author:bartonjs
Assignees:-
Labels:

area-System.Security

Milestone:-

@vcsjones

vcsjones commented Jan 27, 2022

Copy link
Copy Markdown
Member

Does this need to be applied to the Pem ones as well?

runtime/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyPemTests.cs

Line 10 in 027d755

publicsealedclassECDsaKeyPemTests:ECKeyPemTests<ECDsa>

They are modeled similarly as the ones you disabled. Is it possible they will be problematic for whatever reason the ones you disabled are?

@bartonjs

bartonjs commented Jan 27, 2022

Copy link
Copy Markdown
MemberAuthor

Does this need to be applied to the Pem ones as well?

Per local testing, disabling just these two types (ultimately the base class that powers them) was enough. It'll get CI off the floor and let my compatriots in the OS group figure out what went wrong.

@stephentoub
stephentoub merged commit 10df829 into dotnet:mainJan 27, 2022
@bartonjs

bartonjs commented Jan 28, 2022

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1759096282

@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2022
Merged
@bartonjs
bartonjs deleted the avoid_cng_lockup branch January 28, 2022 00:19
@ghostghost locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@bartonjsbartonjs

Labels

area-System.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartonjs@vcsjones@stephentoub