Skip to content

#51371 removed CaseInsensitivePlatforms and CaseSensitivePlatforms parameters - #64440

Merged
mkhamoyan merged 1 commit into
dotnet:mainfrom
mkhamoyan:51371_refactor_casesensitive_tests
Jan 28, 2022
Merged

#51371 removed CaseInsensitivePlatforms and CaseSensitivePlatforms parameters#64440
mkhamoyan merged 1 commit into
dotnet:mainfrom
mkhamoyan:51371_refactor_casesensitive_tests

Conversation

@mkhamoyan

@mkhamoyanmkhamoyan commented Jan 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

#51371 Refactored casesesintive test cases to use IsCaseSensitiveOS and IsCaseInsensitiveOS.

@ghostghost assigned mkhamoyanJan 28, 2022
@ghostghost added the area-System.IO label Jan 28, 2022
@ghost

ghost commented Jan 28, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Refactored casesesintive test cases to use IsCaseSensitiveOS and IsCaseInsensitiveOS.

Author:mkhamoyan
Assignees:mkhamoyan
Labels:

area-System.IO

Milestone:-

@mkhamoyan

mkhamoyan commented Jan 28, 2022

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-extra-platforms

@azure-pipelines

azure-pipelinesBot commented Jan 28, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

adamsitnik
adamsitnik reviewed Jan 28, 2022
View reviewed changes
Comment threadsrc/libraries/System.IO.FileSystem/tests/Directory/Exists.cs

[Fact]
[PlatformSpecific(CaseInsensitivePlatforms)]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsCaseInsensitiveOS))]

@adamsitnikadamsitnikJan 28, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my education: what is the benefit of doing that?

@mkhamoyanmkhamoyanJan 28, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we had 2 ways to check "case sensitivity" having only one will make it it less confusing. And I kept boolean parameter because in some places only bool can be used.

@danmoseley

danmoseley commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

If you put the issue ID in the description then it becomes hyperlinked. You can also put "Fixes ..." if the merge should close the issue.

adamsitnik
adamsitnik approved these changes Jan 28, 2022
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for explaining me why this change was needed.

@mkhamoyan
mkhamoyan merged commit 8766a1c into dotnet:mainJan 28, 2022
@ghostghost locked as resolved and limited conversation to collaborators Feb 27, 2022
@mkhamoyan
mkhamoyan deleted the 51371_refactor_casesensitive_tests branch August 19, 2022 12:45
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@adamsitnikadamsitnikadamsitnik approved these changes
@MaximLipninMaximLipninAwaiting requested review from MaximLipnin
@steveisoksteveisokAwaiting requested review from steveisok
@directhexdirecthexAwaiting requested review from directhex
@lateralusXlateralusXAwaiting requested review from lateralusX
@simonrozsivalsimonrozsivalAwaiting requested review from simonrozsival
@mdh1418mdh1418Awaiting requested review from mdh1418
+1 more reviewer
@danmoseleydanmoseleydanmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mkhamoyanmkhamoyan

Labels

area-System.IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkhamoyan@danmoseley@akoeplinger@adamsitnik