Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix DateOnly and TimeOnly Formatting using interpolated strings - #64460
Merged
Conversation
ghost
commented
Jan 28, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Jan 28, 2022
Tagging subscribers to this area: @dotnet/area-system-runtime |
tarekgh
commented
Jan 28, 2022
Member
tarekgh
commented
Jan 28, 2022
Member
The failures in the CI are tracked by the issue #64389. |
ericstj
approved these changes
Jan 31, 2022
safern
commented
Feb 7, 2022
Member
Test failure is: #64389 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64398 to release/6.0
/cc @tarekgh
Customer Impact
Customer reported in #64292. These types are new in 6.0.
Anyone trying to format a DateOnly or TimeOnly object using an interpolated string with a wrong format specifier will lead to an infinite loop.
The actual cause was the implementation of the interface ISpanFormattable.TryFormat was assumed to return false in the case of formatting failure instead of throwing an exception.
Testing
I have added more tests for the cases concerned and passed the regressions and CI tests.
Risk
Very low as the change scoped to the failure case of the formatting to avoid the infinite loops and throw an exception instead.